Bug 107706 - [BlackBerry] Take a better guess as to what text the user wants learned
Summary: [BlackBerry] Take a better guess as to what text the user wants learned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 10:52 PST by Nima Ghanavatian
Modified: 2013-01-23 11:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2013-01-23 10:53 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-01-23 10:52:36 PST 
If we still have a valid caret position, use it to give priority to a region
of text.  We now take the text before the caret, instead of the text at the end
of the field.  If the caret is not present, we start from the beginning of the field.
this helps learning in email where the region of interest is generally at the start,
not end of the field.
Comment 1 Nima Ghanavatian 2013-01-23 10:53:53 PST 
Created attachment 184264 [details]
Patch
Comment 2 Rob Buis 2013-01-23 11:21:53 PST 
Comment on attachment 184264 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-01-23 11:51:23 PST 
Comment on attachment 184264 [details]
Patch

Clearing flags on attachment: 184264

Committed r140564: <http://trac.webkit.org/changeset/140564>
Comment 4 WebKit Review Bot 2013-01-23 11:51:27 PST 
All reviewed patches have been landed.  Closing bug.