Bug 107700 - [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering
Summary: [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 09:33 PST by Scott Graham
Modified: 2013-01-23 14:51 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-01-23 10:25 PST, Scott Graham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2013-01-23 09:33:36 PST 
[Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering
Comment 1 Scott Graham 2013-01-23 10:25:38 PST 
Created attachment 184258 [details]
Patch
Comment 2 Scott Graham 2013-01-23 10:30:31 PST 
The ['exclude', '.*'], in these targets was excluding the pch cpp file from WinPrecompile.gypi. This works anyway in VS2010 (though is wrong), but VS2012 errors out. Goes with https://codereview.chromium.org/12052029/.
Comment 3 WebKit Review Bot 2013-01-23 14:51:04 PST 
Comment on attachment 184258 [details]
Patch

Clearing flags on attachment: 184258

Committed r140598: <http://trac.webkit.org/changeset/140598>
Comment 4 WebKit Review Bot 2013-01-23 14:51:07 PST 
All reviewed patches have been landed.  Closing bug.