Bug 107698 - Web Inspector: expand more chunks in DTE
Summary: Web Inspector: expand more chunks in DTE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 08:49 PST by Andrey Lushnikov
Modified: 2013-01-24 09:40 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.28 KB, patch)
2013-01-23 08:53 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (4.55 KB, patch)
2013-01-24 00:51 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (2.99 KB, patch)
2013-01-24 06:05 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (2.98 KB, patch)
2013-01-24 07:22 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-23 08:49:07 PST
Prior to this moment, only visible chunks get expanded and highlighted, so if user does a scrolling via mouse wheel he might notice highlighter at work. Expanding some more chunks around visible area should improve user experience.
Comment 1 Andrey Lushnikov 2013-01-23 08:53:56 PST
Created attachment 184248 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-23 11:17:24 PST
Comment on attachment 184248 [details]
Patch

Attachment 184248 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16078284

New failing tests:
inspector/editor/text-editor-selection.html
Comment 3 Build Bot 2013-01-23 16:55:15 PST
Comment on attachment 184248 [details]
Patch

Attachment 184248 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16075397

New failing tests:
inspector/editor/text-editor-selection.html
Comment 4 Build Bot 2013-01-23 17:27:23 PST
Comment on attachment 184248 [details]
Patch

Attachment 184248 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16072459

New failing tests:
inspector/editor/text-editor-selection.html
Comment 5 Andrey Lushnikov 2013-01-24 00:51:05 PST
Created attachment 184428 [details]
Patch
Comment 6 Pavel Feldman 2013-01-24 05:09:59 PST
Comment on attachment 184428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184428&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:936
> +        return this.findVisibleChunks(Math.max(visibleFrom - clientHeight, 0), visibleTo + clientHeight);

Just patch findVisibleChunks?
Comment 7 Andrey Lushnikov 2013-01-24 06:05:04 PST
Created attachment 184474 [details]
Patch
Comment 8 Pavel Feldman 2013-01-24 06:11:57 PST
Comment on attachment 184474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:897
> +        var expand = (visibleTo - visibleFrom) * 0.5;

var span
Comment 9 Andrey Lushnikov 2013-01-24 07:21:57 PST
Comment on attachment 184474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review

>> Source/WebCore/inspector/front-end/DefaultTextEditor.js:897
>> +        var expand = (visibleTo - visibleFrom) * 0.5;
> 
> var span

fixed.
Comment 10 Andrey Lushnikov 2013-01-24 07:22:44 PST
Created attachment 184488 [details]
Patch
Comment 11 WebKit Review Bot 2013-01-24 09:40:47 PST
Comment on attachment 184488 [details]
Patch

Clearing flags on attachment: 184488

Committed r140691: <http://trac.webkit.org/changeset/140691>
Comment 12 WebKit Review Bot 2013-01-24 09:40:51 PST
All reviewed patches have been landed.  Closing bug.