Bug 107695 - [Qt][WebGL] regression(139725) Execution flow never reaches server side part in GraphicsSurface::platformSwapBuffers()
Summary: [Qt][WebGL] regression(139725) Execution flow never reaches server side part ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 08:02 PST by Viatcheslav Ostapenko
Modified: 2013-01-23 10:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2013-01-23 08:16 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2013-01-23 08:02:21 PST 
This change is not right:
-    if (m_private->isReceiver()) {
+    if (m_private->isReceiver() && platformGetTextureID()) {

platformTextureID() creates texture and always returns it, so making server side code unreachable.
Comment 1 Viatcheslav Ostapenko 2013-01-23 08:16:54 PST 
Created attachment 184241 [details]
Patch
Comment 2 Kalyan 2013-01-23 09:40:57 PST 
Comment on attachment 184241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184241&action=review

> Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:558
> +    if (m_private->isReceiver()) {

Shouldn't isReceiver() return false on server side??
Comment 3 Zeno Albisser 2013-01-23 10:08:42 PST 
I am afraid, that this does not fix the issue.
After applying this patch i still do not get any WebGL content.
Comment 4 Kalyan 2013-01-23 10:21:21 PST 
(In reply to comment #3)
> I am afraid, that this does not fix the issue.
> After applying this patch i still do not get any WebGL content.

I don’t understand as to what we are fixing with this patch. On server side isReceiver() should always return false and we dont evaluate the second condition(i.e We use logical And and not or )
Comment 5 Viatcheslav Ostapenko 2013-01-23 10:41:17 PST 
Kalyan is right.
Comment 6 Viatcheslav Ostapenko 2013-01-23 10:45:49 PST 
(In reply to comment #3)
> I am afraid, that this does not fix the issue.
> After applying this patch i still do not get any WebGL content.

I'll try older NVidia cards. I have 9500 GT in one computer.
Don't have problems with GT 550 Ti.