Bug 107692 – [Curl] There is no way for a WebKit client to set the Curl cookie jar path

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

There exists a method setCookieJarFileName() in WebCore\platform\network\curl\ResourceHandleManager.cpp,
but noone uses it.

Created attachment 184233 [details]
Patch

Setting the Curl cookie jar path makes Curl enable cookies, which is important for many sites to work.

Created attachment 185502 [details]
Patch

Modified patch to set a default cookie jar path, this will enable the Curl cookie engine by default (and persistent cookies).

[Brent Fulgham]

Comment on attachment 185502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185502&action=review

Thanks for working on this.  I think it would be cleaner if you encapsulated this in a helper function (like I did with the "certificatePath").  Then we can provide port-specific logic for identifying where the cookie jar should live.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:122
> +    , m_cookieJarFileName("cookies.dat")

I would prefer you write a helper function like "certificatePath" that encapsulates the identification of this cook jar.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:137
> +        m_cookieJarFileName = fastStrDup(cookieJarPath);

This logic should go in the helper function.  Then I can add a CF-variant without cluttering the code.

Created attachment 185780 [details]
Patch

Modified patch according to review comments.

[Brent Fulgham]

Comment on attachment 185780 [details]
Patch

Looks great!

(In reply to comment #8)
> (From update of attachment 185780 [details])
> Looks great!

Thanks for the review ;)

[WebKit Review Bot]

Comment on attachment 185780 [details]
Patch

Clearing flags on attachment: 185780

Committed r141464: <http://trac.webkit.org/changeset/141464>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.