Bug 107688 - Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames
Summary: Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 07:24 PST by Andrey Adaikin
Modified: 2013-01-24 05:44 PST (History)
8 users (show)

See Also:

Attachments
Patch (29.00 KB, patch)
2013-01-23 07:31 PST, Andrey Adaikin 		pfeldman: review+
Details | Formatted Diff | Diff
Screenshot (141.38 KB, image/png)
2013-01-23 07:33 PST, Andrey Adaikin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-01-23 07:24:18 PST 
Allow capturing several canvas frames in a row.

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-23 07:31:33 PST 
Created attachment 184227 [details]
Patch
Comment 2 Andrey Adaikin 2013-01-23 07:33:42 PST 
Created attachment 184228 [details]
Screenshot
Comment 3 Pavel Feldman 2013-01-23 07:36:43 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
> +            setTimeout(this._requestTraceLog.bind(this), 500);

why 500?
Comment 4 Andrey Adaikin 2013-01-23 07:52:21 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
>> +            setTimeout(this._requestTraceLog.bind(this), 500);
> 
> why 500?

just a number :) any concerns/ideas?
Comment 5 Pavel Feldman 2013-01-23 07:58:14 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

>>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
>>> +            setTimeout(this._requestTraceLog.bind(this), 500);
>> 
>> why 500?
> 
> just a number :) any concerns/ideas?

Why do you have this delay? Why do you use magic numbers?
Comment 6 Andrey Adaikin 2013-01-23 08:11:11 PST 
(In reply to comment #5)
> (From update of attachment 184227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review
> 
> >>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
> >>> +            setTimeout(this._requestTraceLog.bind(this), 500);
> >> 
> >> why 500?
> > 
> > just a number :) any concerns/ideas?
> 
> Why do you have this delay? Why do you use magic numbers?

We have an alive trace log which we must fetch periodically from the backend. To send a new request right away seems too inefficient, thus I timeout a bit.
Comment 7 Andrey Adaikin 2013-01-24 05:44:28 PST 
Committed r140678: <http://trac.webkit.org/changeset/140678>