RESOLVED FIXED 107648
Web Inspector: allow user to resize inspector window by dragging the toolbar 
https://bugs.webkit.org/show_bug.cgi?id=107648
Summary Web Inspector: allow user to resize inspector window by dragging the toolbar
Dmitry Gozman
Reported 2013-01-23 01:46:42 PST
When user drags toolbar in docked to bottom mode, we should change the height of the inspector window.
Attachments
Patch (6.50 KB, patch)
2013-01-23 03:08 PST, Dmitry Gozman 		no flags
DetailsFormatted DiffDiff
Patch (6.72 KB, patch)
2013-01-23 04:45 PST, Dmitry Gozman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Gozman
Comment 1 2013-01-23 03:08:40 PST
Created attachment 184189 [details] Patch
WebKit Review Bot
Comment 2 2013-01-23 03:10:42 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Pavel Feldman
Comment 3 2013-01-23 04:15:57 PST
Comment on attachment 184189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184189&action=review A couple of nits and it is good to land. > Source/WebCore/inspector/front-end/DockController.js:97 > + isDockedToBottom: function() { { should be on the next line > Source/WebCore/inspector/front-end/DockController.js:-125 > - WebInspector.toolbar.setDockedToBottom(this._dockSide === WebInspector.DockController.State.DockedToBottom); I like reversing this dependency. > Source/WebCore/inspector/front-end/Toolbar.js:124 > + this.element.lastHeight = window.innerHeight; Why storing this property on element? Store it on this with private field.
Dmitry Gozman
Comment 4 2013-01-23 04:45:45 PST
Created attachment 184202 [details] Patch
WebKit Review Bot
Comment 5 2013-01-23 10:24:07 PST
Comment on attachment 184202 [details] Patch Clearing flags on attachment: 184202 Committed r140543: <http://trac.webkit.org/changeset/140543>
WebKit Review Bot
Comment 6 2013-01-23 10:24:11 PST
All reviewed patches have been landed. Closing bug.
Andrey Adaikin
Comment 7 2013-01-24 05:41:14 PST
FYI. plz get used to run JSCompiler WebCore/inspector/compile-front-end.py from time to time: Source/WebCore/inspector/front-end/Toolbar.js:104: WARNING - inconsistent return type found : (boolean|null) required: boolean return WebInspector.dockController && WebInspector.dockController.isDockedToBottom();
Note You need to log in before you can comment on or make changes to this bug.