Bug 107643 - Removing command line shortening as it makes it difficult to see the command during errors.
Summary: Removing command line shortening as it makes it difficult to see the command ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim 'mithro' Ansell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 00:42 PST by Tim 'mithro' Ansell
Modified: 2013-01-23 02:08 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2013-01-23 00:42 PST, Tim 'mithro' Ansell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 'mithro' Ansell 2013-01-23 00:42:19 PST 
Removing command line shortening as it makes it difficult to see the command during errors.
Comment 1 Tim 'mithro' Ansell 2013-01-23 00:42:40 PST 
Created attachment 184169 [details]
Patch
Comment 2 Tim 'mithro' Ansell 2013-01-23 00:49:21 PST 
Example case where this is annoying;

Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews

Running Python unit tests
Failed to run "['Tools/Scripts/test-webkitpy', '--all']" exit_code: 1

We then include 500 lines of history, so it's not a case of wasting the space...
Comment 3 Eric Seidel (no email) 2013-01-23 01:02:39 PST 
Comment on attachment 184169 [details]
Patch

I'm not sure what this does?
Comment 4 Alan Cutter 2013-01-23 01:09:52 PST 
Sheriffbot will not output lines longer than IRC's limit (a bit over 400 characters) as multiple posts so there is some safe guard against #webkit being completely flooded if Sheriffbot posts an error.

LGTM.
Comment 5 Tim 'mithro' Ansell 2013-01-23 01:12:54 PST 
Currently when returning a ScriptError it restricts the args output part to be 100 characters wide.

You get something like;
Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews]"

Rather than the command which actually failed, and hence you can't reproduce the problem.
Comment 6 Eric Seidel (no email) 2013-01-23 02:04:22 PST 
Comment on attachment 184169 [details]
Patch

OK.  We could obviously make this output much prettier. :)  But making it more useful is probably a good first step.
Comment 7 WebKit Review Bot 2013-01-23 02:08:26 PST 
Comment on attachment 184169 [details]
Patch

Clearing flags on attachment: 184169

Committed r140528: <http://trac.webkit.org/changeset/140528>
Comment 8 WebKit Review Bot 2013-01-23 02:08:30 PST 
All reviewed patches have been landed.  Closing bug.