Bug 107643 – Removing command line shortening as it makes it difficult to see the command during errors.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim 'mithro' Ansell]

Removing command line shortening as it makes it difficult to see the command during errors.

[Tim 'mithro' Ansell]

Created attachment 184169 [details]
Patch

[Tim 'mithro' Ansell]

Example case where this is annoying;

Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews

Running Python unit tests
Failed to run "['Tools/Scripts/test-webkitpy', '--all']" exit_code: 1

We then include 500 lines of history, so it's not a case of wasting the space...

[Eric Seidel (no email)]

Comment on attachment 184169 [details]
Patch

I'm not sure what this does?

[Alan Cutter]

Sheriffbot will not output lines longer than IRC's limit (a bit over 400 characters) as multiple posts so there is some safe guard against #webkit being completely flooded if Sheriffbot posts an error.

LGTM.

[Tim 'mithro' Ansell]

Currently when returning a ScriptError it restricts the args output part to be 100 characters wide.

You get something like;
Failed to run "['/mnt/git/webkit-chromium-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-chromium-ews]"

Rather than the command which actually failed, and hence you can't reproduce the problem.

[Eric Seidel (no email)]

Comment on attachment 184169 [details]
Patch

OK.  We could obviously make this output much prettier. :)  But making it more useful is probably a good first step.

[WebKit Review Bot]

Comment on attachment 184169 [details]
Patch

Clearing flags on attachment: 184169

Committed r140528: <http://trac.webkit.org/changeset/140528>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.