Bug 107641 – always NP plugin exception message show "Error calling method on NPObject."

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Plug-ins

if np plugin throw some error exception message to browser, webkit ignore that and show "Error calling method on NPObject." text only


in c_instance.cpp, we can see code like this

    {
        JSLock::DropAllLocks dropAllLocks(exec);
        ASSERT(globalExceptionString().isNull());
        retval = _object->_class->invoke(_object, ident, cArgs.data(), count, &resultVariant);
        moveGlobalExceptionToExecState(exec);
    }
    
    if (!retval)
        throwError(exec, createError(exec, "Error calling method on NPObject."));


in case throw exception inside np plugin function, np plugin function call is fail, so 'retval' is false

and in case of that kind of situation, inside moveGlobalExceptionToExecState function, make error exception, but after moveGlobalExceptionToExecState call,  throwError is called, so message made inside np plugin is overwritten 

so I changed moveGlobalExceptionToExecState function, moveGlobalExceptionToExecState have bool type retun value, if  inside moveGlobalExceptionToExecState  throwError is called , this function return true, in that case,  throwError(exec, createError(exec, "Error calling method on NPObject.")) is not called, like this


 {
        JSLock::DropAllLocks dropAllLocks(exec);
        ASSERT(globalExceptionString().isNull());
        retval = _object->_class->invokeDefault(_object, cArgs.data(), count, &resultVariant);
        bexcretval = moveGlobalExceptionToExecState(exec);
    }
    

  	if (!retval && !bexcretval)
  	throwError(exec, createError(exec, "Error calling method on NPObject."));

[Alexey Proskuryakov]

Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.