Bug 107636 - [V8] Make an Isolate parameter mandatory in throwError()
Summary: [V8] Make an Isolate parameter mandatory in throwError()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 23:35 PST by Kentaro Hara
Modified: 2013-01-23 00:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2013-01-22 23:37 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (5.23 KB, patch)
2013-01-22 23:56 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-22 23:35:15 PST 
[V8] Make an Isolate parameter mandatory in throwError()
Comment 1 Kentaro Hara 2013-01-22 23:37:07 PST 
Created attachment 184157 [details]
Patch
Comment 2 Kentaro Hara 2013-01-22 23:37:56 PST 
Comment on attachment 184157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review

> Source/WebCore/bindings/v8/V8Binding.h:466
> +    // FIXME: This should receive an Isolate.

I found that this requires a bunch of fixes. I'll do it later.
Comment 3 Adam Barth 2013-01-22 23:45:44 PST 
Comment on attachment 184157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review

> Source/WebCore/bindings/v8/WorkerScriptController.cpp:174
> -            state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data());
> +            state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data(), m_context.get()->GetIsolate());

You shouldn't need to call get().  We've overloaded operator->
Comment 4 Kentaro Hara 2013-01-22 23:56:29 PST 
Created attachment 184163 [details]
patch for landing
Comment 5 WebKit Review Bot 2013-01-23 00:29:42 PST 
Comment on attachment 184163 [details]
patch for landing

Clearing flags on attachment: 184163

Committed r140516: <http://trac.webkit.org/changeset/140516>
Comment 6 WebKit Review Bot 2013-01-23 00:29:45 PST 
All reviewed patches have been landed.  Closing bug.