RESOLVED FIXED107636
[V8] Make an Isolate parameter mandatory in throwError() 
https://bugs.webkit.org/show_bug.cgi?id=107636
Summary [V8] Make an Isolate parameter mandatory in throwError()
Kentaro Hara
Reported 2013-01-22 23:35:15 PST
[V8] Make an Isolate parameter mandatory in throwError()
Attachments
Patch (5.25 KB, patch)
2013-01-22 23:37 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (5.23 KB, patch)
2013-01-22 23:56 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-22 23:37:07 PST
Created attachment 184157 [details] Patch
Kentaro Hara
Comment 2 2013-01-22 23:37:56 PST
Comment on attachment 184157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review > Source/WebCore/bindings/v8/V8Binding.h:466 > + // FIXME: This should receive an Isolate. I found that this requires a bunch of fixes. I'll do it later.
Adam Barth
Comment 3 2013-01-22 23:45:44 PST
Comment on attachment 184157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184157&action=review > Source/WebCore/bindings/v8/WorkerScriptController.cpp:174 > - state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data()); > + state->exception = throwError(v8GeneralError, state->errorMessage.utf8().data(), m_context.get()->GetIsolate()); You shouldn't need to call get(). We've overloaded operator->
Kentaro Hara
Comment 4 2013-01-22 23:56:29 PST
Created attachment 184163 [details] patch for landing
WebKit Review Bot
Comment 5 2013-01-23 00:29:42 PST
Comment on attachment 184163 [details] patch for landing Clearing flags on attachment: 184163 Committed r140516: <http://trac.webkit.org/changeset/140516>
WebKit Review Bot
Comment 6 2013-01-23 00:29:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.