Bug 107635 - Run test-webkitpy (with --all) on a build-and-test run.
Summary: Run test-webkitpy (with --all) on a build-and-test run.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 79404 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-22 23:33 PST by Tim 'mithro' Ansell
Modified: 2013-04-01 19:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.70 KB, patch)
2013-01-22 23:33 PST, Tim 'mithro' Ansell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 'mithro' Ansell 2013-01-22 23:33:21 PST
Run test-webkitpy (with --all) on a build-and-test run.
Comment 1 Tim 'mithro' Ansell 2013-01-22 23:33:44 PST
Created attachment 184156 [details]
Patch
Comment 2 Tim 'mithro' Ansell 2013-01-23 01:21:21 PST
From IRC;

<abarth> mithro: if any of the tests fail
<abarth> we might block the EWS bots
<abarth> what we did for webkit_unit_tests
<abarth> was to teach the EWS which individual tests fail
<abarth> so that it can compare the set of failing tests before and after applying a patch
Comment 3 Eric Seidel (no email) 2013-01-23 01:48:41 PST
Comment on attachment 184156 [details]
Patch

Isn't this just going to block all EWS whenever a python test is failing on trunk? :)
Comment 4 Eric Seidel (no email) 2013-01-23 01:49:15 PST
We don't currently have any way to detect and ignore python failures, unless I'm mistaken.  Thus even a brief failure of a python test will disable all test-based EWS bots, which seems bad.
Comment 5 Dirk Pranke 2013-01-31 15:07:00 PST
FWIW, I would break this into two patches, one that adds support for test-webkit w/o --all, and one that adds --all. As I mentioned somewhere in another bug, we should eventually get rid of --all and fold the exclusions into the other flags like --integration-tests).
Comment 6 Tim 'mithro' Ansell 2013-01-31 15:40:04 PST
Agreed.
Comment 7 Tim 'mithro' Ansell 2013-03-04 17:11:24 PST
Abandoning this change.
Comment 8 Tim 'mithro' Ansell 2013-04-01 19:36:00 PDT
*** Bug 79404 has been marked as a duplicate of this bug. ***