Bug 107620 - Make MediaQueryEvaluator(bool) constructor explicit.
Summary: Make MediaQueryEvaluator(bool) constructor explicit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 20:39 PST by Hayato Ito
Modified: 2013-01-22 21:16 PST (History)
9 users (show)

See Also:

Attachments
Make it explicit (1.42 KB, patch)
2013-01-22 20:43 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Fix a title. (1.42 KB, patch)
2013-01-22 20:46 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-01-22 20:39:55 PST 
I had to confess that I've spent a couple of hours on debugging due to this non-explicit constructor.

RuleSet:::addRulesFromSheet is defined:
  RuleSet:addRulesFromSheet(StyleSheetContents*, const MediaQueryEvaluator&, StyleResolver* = 0, const ContainerNode* = 0)

I wrongly called it with 'ruleSet.addRulesFromSheet(sheet, resolver)'. My bad. :(
Comment 1 Hayato Ito 2013-01-22 20:43:12 PST 
Created attachment 184119 [details]
Make it explicit
Comment 2 Hayato Ito 2013-01-22 20:46:41 PST 
Created attachment 184120 [details]
Fix a title.
Comment 3 Shinya Kawanaka 2013-01-22 21:02:36 PST 
Looks ok if all build-bots pass.
Comment 4 WebKit Review Bot 2013-01-22 21:16:10 PST 
Comment on attachment 184120 [details]
Fix a title.

Clearing flags on attachment: 184120

Committed r140503: <http://trac.webkit.org/changeset/140503>
Comment 5 WebKit Review Bot 2013-01-22 21:16:14 PST 
All reviewed patches have been landed.  Closing bug.