RESOLVED FIXED 107620
Make MediaQueryEvaluator(bool) constructor explicit. 
https://bugs.webkit.org/show_bug.cgi?id=107620
Summary Make MediaQueryEvaluator(bool) constructor explicit.
Hayato Ito
Reported 2013-01-22 20:39:55 PST
I had to confess that I've spent a couple of hours on debugging due to this non-explicit constructor. RuleSet:::addRulesFromSheet is defined: RuleSet:addRulesFromSheet(StyleSheetContents*, const MediaQueryEvaluator&, StyleResolver* = 0, const ContainerNode* = 0) I wrongly called it with 'ruleSet.addRulesFromSheet(sheet, resolver)'. My bad. :(
Attachments
Make it explicit (1.42 KB, patch)
2013-01-22 20:43 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Fix a title. (1.42 KB, patch)
2013-01-22 20:46 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2013-01-22 20:43:12 PST
Created attachment 184119 [details] Make it explicit
Hayato Ito
Comment 2 2013-01-22 20:46:41 PST
Created attachment 184120 [details] Fix a title.
Shinya Kawanaka
Comment 3 2013-01-22 21:02:36 PST
Looks ok if all build-bots pass.
WebKit Review Bot
Comment 4 2013-01-22 21:16:10 PST
Comment on attachment 184120 [details] Fix a title. Clearing flags on attachment: 184120 Committed r140503: <http://trac.webkit.org/changeset/140503>
WebKit Review Bot
Comment 5 2013-01-22 21:16:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.