Bug 107604 - [CSS Grid Layout] Add support for max-content
Summary: [CSS Grid Layout] Add support for max-content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 103311
  Show dependency tree / graph
 
Reported: 2013-01-22 17:36 PST by Julien Chaffraix
Modified: 2013-01-23 13:38 PST (History)
6 users (show)

See Also:

Attachments
Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now. (17.27 KB, patch)
2013-01-22 17:51 PST, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch for landing (17.05 KB, patch)
2013-01-23 12:48 PST, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-01-22 17:36:51 PST 
Following bug 106474, we have support for min-content but not max-content. This bug corrects this mistake by implementing the missing part of minmax.
Comment 1 Julien Chaffraix 2013-01-22 17:51:21 PST 
Created attachment 184095 [details]
Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now.
Comment 2 Tony Chang 2013-01-23 11:45:42 PST 
Comment on attachment 184095 [details]
Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now.

View in context: https://bugs.webkit.org/attachment.cgi?id=184095&action=review

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:10
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:17
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:10
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:17
> +    display: -webkit-grid;

Can you use grid class in grid.css instead?

> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:32
> +    background-color: blue;
> +    -webkit-grid-column: 1;
> +    -webkit-grid-row: 1;

This seems redundant with the code in grid.css.
Comment 3 Julien Chaffraix 2013-01-23 11:52:20 PST 
Comment on attachment 184095 [details]
Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now.

View in context: https://bugs.webkit.org/attachment.cgi?id=184095&action=review

Thanks Tony!

>> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:10
>> +    display: -webkit-grid;
> 
> Can you use grid class in grid.css instead?

Doh! So much for upgrading these tests to grid.css :-/

All those comments will be taking into account and I will double check the file prior to landing.
Comment 4 Julien Chaffraix 2013-01-23 12:48:58 PST 
Created attachment 184288 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-01-23 13:38:22 PST 
Comment on attachment 184288 [details]
Patch for landing

Clearing flags on attachment: 184288

Committed r140583: <http://trac.webkit.org/changeset/140583>
Comment 6 WebKit Review Bot 2013-01-23 13:38:26 PST 
All reviewed patches have been landed.  Closing bug.