Bug 107592 - [Chromium] Correct auto-zoom when using compositor scaling
Summary: [Chromium] Correct auto-zoom when using compositor scaling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 14:57 PST by Xianzhu Wang
Modified: 2019-07-18 16:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (25.69 KB, patch)
2013-01-22 15:04 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Updated patch (22.41 KB, patch)
2013-01-22 17:27 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2013-01-22 14:57:45 PST 
Need to correct auto-zoom when using compositor scaling (applyDeviceScaleFactorInCompositor() and applyPageScaleFactorInCompositor()).
Comment 1 Xianzhu Wang 2013-01-22 15:02:25 PST 
        1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
        2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
Comment 2 Xianzhu Wang 2013-01-22 15:04:03 PST 
Created attachment 184056 [details]
Patch
Comment 3 Xianzhu Wang 2013-01-22 15:38:06 PST 
The patch is now conflicting with aelias@'s change. Will update after that change is landed.
Comment 4 Xianzhu Wang 2013-01-22 17:27:22 PST 
Created attachment 184090 [details]
Updated patch
Comment 5 Xianzhu Wang 2013-01-22 17:28:24 PST 
The new patch no longer conflicts with the patch of bug 107424.
Comment 6 Adam Barth 2013-01-28 12:31:16 PST 
Comment on attachment 184090 [details]
Updated patch

Thanks for the tests.
Comment 7 WebKit Review Bot 2013-01-28 13:09:51 PST 
Comment on attachment 184090 [details]
Updated patch

Clearing flags on attachment: 184090

Committed r140994: <http://trac.webkit.org/changeset/140994>
Comment 8 WebKit Review Bot 2013-01-28 13:09:55 PST 
All reviewed patches have been landed.  Closing bug.