WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 107592
[Chromium] Correct auto-zoom when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107592
Summary
[Chromium] Correct auto-zoom when using compositor scaling
Xianzhu Wang
Reported
2013-01-22 14:57:45 PST
Need to correct auto-zoom when using compositor scaling (applyDeviceScaleFactorInCompositor() and applyPageScaleFactorInCompositor()).
Attachments
Patch
(25.69 KB, patch)
2013-01-22 15:04 PST
,
Xianzhu Wang
no flags
Details
Formatted Diff
Diff
Updated patch
(22.41 KB, patch)
2013-01-22 17:27 PST
,
Xianzhu Wang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Xianzhu Wang
Comment 1
2013-01-22 15:02:25 PST
1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling; 2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
Xianzhu Wang
Comment 2
2013-01-22 15:04:03 PST
Created
attachment 184056
[details]
Patch
Xianzhu Wang
Comment 3
2013-01-22 15:38:06 PST
The patch is now conflicting with aelias@'s change. Will update after that change is landed.
Xianzhu Wang
Comment 4
2013-01-22 17:27:22 PST
Created
attachment 184090
[details]
Updated patch
Xianzhu Wang
Comment 5
2013-01-22 17:28:24 PST
The new patch no longer conflicts with the patch of
bug 107424
.
Adam Barth
Comment 6
2013-01-28 12:31:16 PST
Comment on
attachment 184090
[details]
Updated patch Thanks for the tests.
WebKit Review Bot
Comment 7
2013-01-28 13:09:51 PST
Comment on
attachment 184090
[details]
Updated patch Clearing flags on attachment: 184090 Committed
r140994
: <
http://trac.webkit.org/changeset/140994
>
WebKit Review Bot
Comment 8
2013-01-28 13:09:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug