WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
107591
Fix build when DRAG_SUPPORT is disabled.
https://bugs.webkit.org/show_bug.cgi?id=107591
Summary
Fix build when DRAG_SUPPORT is disabled.
Daker Fernandes Pinheiro
Reported
2013-01-22 14:53:42 PST
Some files makes use of a function defined only when DRAG_SUPPORT enabled. However, this usage is not guarded by DRAG_SUPPORT.
Attachments
Adding DRAG_SUPPORT where I suppose to be necessary
(2.29 KB, patch)
2013-01-22 14:57 PST
,
Daker Fernandes Pinheiro
darin
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daker Fernandes Pinheiro
Comment 1
2013-01-22 14:57:27 PST
Created
attachment 184055
[details]
Adding DRAG_SUPPORT where I suppose to be necessary
Daker Fernandes Pinheiro
Comment 2
2013-01-22 15:00:53 PST
David, could you review this patch?
WebKit Commit Bot
Comment 3
2013-04-08 18:08:07 PDT
Comment on
attachment 184055
[details]
Adding DRAG_SUPPORT where I suppose to be necessary Rejecting
attachment 184055
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184055, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ucceeded at 1 with fuzz 3. patching file Source/WebCore/page/AutoscrollController.cpp Hunk #1 FAILED at 257. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/page/AutoscrollController.cpp.rej patching file Source/WebCore/page/EventHandler.cpp Hunk #1 succeeded at 796 (offset 36 lines). Hunk #2 succeeded at 811 (offset 34 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-commit-queue.appspot.com/results/17613013
Anne van Kesteren
Comment 4
2023-12-28 08:38:41 PST
This seems to be going fine now with two Apple platforms not enabling this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug