Bug 107569 - BackgroundHTMLParser should simulate tree building in a separate function
Summary: BackgroundHTMLParser should simulate tree building in a separate function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-01-22 10:51 PST by Adam Barth
Modified: 2013-01-22 11:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.27 KB, patch)
2013-01-22 10:52 PST, Adam Barth 		tonyg: review+
Details | Formatted Diff | Diff
Patch (6.21 KB, patch)
2013-01-22 10:53 PST, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-01-22 10:51:12 PST 
BackgroundHTMLParser should simulate tree building in a separate function
Comment 1 Adam Barth 2013-01-22 10:52:09 PST 
Created attachment 184017 [details]
Patch
Comment 2 Adam Barth 2013-01-22 10:53:36 PST 
Created attachment 184019 [details]
Patch
Comment 3 Tony Gentilcore 2013-01-22 10:59:34 PST 
Comment on attachment 184017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184017&action=review

> Source/WebCore/html/parser/BackgroundHTMLParser.cpp:129
> +        // FIXME: This is just a copy of Tokenizer::updateStateFor which doesn't use HTMLNames.

This isn't exactly true any more. I'd change it to something like:

// FIXME: This is just a copy of Tokenizer::updateStateFor which uses threadSafeMatches.
Comment 4 Eric Seidel (no email) 2013-01-22 10:59:45 PST 
Comment on attachment 184019 [details]
Patch

LGTM.  We had talked about pulling it out into a separate class even.
Comment 5 Adam Barth 2013-01-22 11:13:45 PST 
Committed r140441: <http://trac.webkit.org/changeset/140441>