Bug 107562 - REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
Summary: REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 10:41 PST by Jer Noble
Modified: 2013-01-22 11:15 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2013-01-22 10:43 PST, Jer Noble 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-01-22 10:41:59 PST 
REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
Comment 1 Jer Noble 2013-01-22 10:43:54 PST 
Created attachment 184011 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-01-22 10:46:12 PST 
Comment on attachment 184011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184011&action=review

r=me

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:113
> +    bool useTiledDrawing = useTiledDrawingValue ? WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue)) : false;

This might read better as:

bool useTiledDrawing = useTiledDrawingValue && WKBooleanGetValue(static_cast<WKBooleanRef>(useTiledDrawingValue));

What do you think?
Comment 3 Jer Noble 2013-01-22 10:54:30 PST 
Nice suggestion actually. :)
Comment 4 Jer Noble 2013-01-22 11:15:36 PST 
Committed r140442: <http://trac.webkit.org/changeset/140442>