Bug 107553 - [chromium] move most WebViewHost printf calls to WebTestProxy
Summary: [chromium] move most WebViewHost printf calls to WebTestProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 107556
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-22 05:59 PST by Dan Carney
Modified: 2013-01-24 02:14 PST (History)
7 users (show)

See Also:


Attachments
Patch (16.57 KB, patch)
2013-01-22 06:00 PST, Dan Carney
no flags Details | Formatted Diff | Diff
Patch (16.67 KB, patch)
2013-01-23 05:16 PST, Dan Carney
no flags Details | Formatted Diff | Diff
Patch (16.65 KB, patch)
2013-01-24 00:22 PST, Dan Carney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2013-01-22 05:59:27 PST
[chromium] move most WebViewHost printf calls to WebTestProxy
Comment 1 Dan Carney 2013-01-22 06:00:30 PST
Created attachment 183978 [details]
Patch
Comment 2 jochen 2013-01-23 05:03:15 PST
Comment on attachment 183978 [details]
Patch

Looks good.

You'll need to rebase this. I verified locally that it works after my fix for bug 107556 landed.
Comment 3 Dan Carney 2013-01-23 05:16:23 PST
Created attachment 184207 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-23 10:27:54 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 WebKit Review Bot 2013-01-23 11:25:33 PST
Comment on attachment 184207 [details]
Patch

Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16063718

New failing tests:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
Comment 6 WebKit Review Bot 2013-01-23 12:00:30 PST
Comment on attachment 184207 [details]
Patch

Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16075281

New failing tests:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
Comment 7 WebKit Review Bot 2013-01-23 12:26:18 PST
Comment on attachment 184207 [details]
Patch

Rejecting attachment 184207 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184207, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
nderTree/chromium/TestShell.cpp
Hunk #1 succeeded at 221 (offset 2 lines).
patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp
Hunk #5 succeeded at 1160 (offset 10 lines).
Hunk #6 succeeded at 1219 (offset 10 lines).
patching file Tools/DumpRenderTree/chromium/WebViewHost.h
Hunk #1 succeeded at 86 (offset 1 line).
Hunk #2 succeeded at 383 (offset 4 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16078325
Comment 8 Dan Carney 2013-01-24 00:22:37 PST
Created attachment 184423 [details]
Patch
Comment 9 Dan Carney 2013-01-24 00:23:13 PST
Comment on attachment 184423 [details]
Patch

rebased
Comment 10 WebKit Review Bot 2013-01-24 01:22:18 PST
Comment on attachment 184423 [details]
Patch

Rejecting attachment 184423 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/16097064
Comment 11 WebKit Review Bot 2013-01-24 02:14:25 PST
Comment on attachment 184423 [details]
Patch

Clearing flags on attachment: 184423

Committed r140668: <http://trac.webkit.org/changeset/140668>
Comment 12 WebKit Review Bot 2013-01-24 02:14:30 PST
All reviewed patches have been landed.  Closing bug.