Bug 107542 - Move top layer flag from ElementRareData to NodeFlags
Summary: Move top layer flag from ElementRareData to NodeFlags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Falkenhagen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 03:01 PST by Matt Falkenhagen
Modified: 2013-01-22 13:42 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.76 KB, patch)
2013-01-22 03:12 PST, Matt Falkenhagen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Falkenhagen 2013-01-22 03:01:16 PST 
Try moving the top layer flag from ElementRareData to NodeFlags. It may fix the perf regression described in bug 106726, and has been suggested earlier, e.g., https://bugs.webkit.org/show_bug.cgi?id=84796#c31

Moving it to NodeFlags also simplifies some of the code and makes it no longer necessary to allocate rare data.
Comment 1 Matt Falkenhagen 2013-01-22 03:12:28 PST 
Created attachment 183951 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-22 04:16:43 PST 
Comment on attachment 183951 [details]
Patch

Clearing flags on attachment: 183951

Committed r140411: <http://trac.webkit.org/changeset/140411>
Comment 3 WebKit Review Bot 2013-01-22 04:16:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ojan Vafai 2013-01-22 13:42:04 PST 
Doesn't look like it fixed the performance regression. :(