Bug 107532 - Avoid unnecessary format conversion for tex{Sub}Image2D() for ImageData of WebGL
Summary: Avoid unnecessary format conversion for tex{Sub}Image2D() for ImageData of WebGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 02:26 PST by Jun Jiang
Modified: 2013-01-23 14:28 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.11 KB, patch)
2013-01-22 02:32 PST, Jun Jiang 		no flags Details | Formatted Diff | Diff
Patch (4.49 KB, patch)
2013-01-22 05:38 PST, Jun Jiang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jun Jiang 2013-01-22 02:26:24 PST 
There is mandatory format conversion existed for tex{Sub}Image2D() for ImageData of WebGL, which could be avoided when the destination format is RGBA and the type is UNSIGNED_BYTE and both the preMultiply and flip flags are false.
Comment 1 Jun Jiang 2013-01-22 02:32:55 PST 
Created attachment 183941 [details]
Patch
Comment 2 Jun Jiang 2013-01-22 05:38:59 PST 
Created attachment 183971 [details]
Patch
Comment 3 Jun Jiang 2013-01-22 05:42:44 PST 
Add two comments in the code to make it easy to maintain.
Comment 4 Kenneth Russell 2013-01-23 13:51:20 PST 
Comment on attachment 183971 [details]
Patch

Looks good. r=me
Comment 5 WebKit Review Bot 2013-01-23 14:28:08 PST 
Comment on attachment 183971 [details]
Patch

Clearing flags on attachment: 183971

Committed r140595: <http://trac.webkit.org/changeset/140595>
Comment 6 WebKit Review Bot 2013-01-23 14:28:11 PST 
All reviewed patches have been landed.  Closing bug.