RESOLVED FIXED 107531
Web Inspector: do not highlight really long lines in DTE. 
https://bugs.webkit.org/show_bug.cgi?id=107531
Summary Web Inspector: do not highlight really long lines in DTE.
Andrey Lushnikov
Reported 2013-01-22 02:20:55 PST
This functionality had been implemented but was lost due to inaccurate refactoring. So one needs to: - implement this one more time - cover this with a layout test to avoid this in future.
Attachments
Patch (8.10 KB, patch)
2013-01-22 02:25 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2013-01-22 04:03 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (9.82 KB, patch)
2013-01-22 06:18 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-01-22 02:25:17 PST
Created attachment 183940 [details] Patch
Pavel Feldman
Comment 2 2013-01-22 03:41:53 PST
Comment on attachment 183940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183940&action=review > Source/WebCore/inspector/front-end/TextEditorHighlighter.js:82 > + syntaxTokenHighligh.ranges.sort(comparator); I thought we don't need sorting anymore. > Source/WebCore/inspector/front-end/TextEditorHighlighter.js:85 > + return syntaxTokenHighligh.ranges.slice(0, lastIndex); Tokenizer should not produce these at the first place, you are trimming them too late. And you produce a lot of garbage (in 99% of cases you are cloning array with no good reason).
Andrey Lushnikov
Comment 3 2013-01-22 03:55:53 PST
Comment on attachment 183940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183940&action=review >> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:82 >> + syntaxTokenHighligh.ranges.sort(comparator); > > I thought we don't need sorting anymore. fixed. >> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:85 >> + return syntaxTokenHighligh.ranges.slice(0, lastIndex); > > Tokenizer should not produce these at the first place, you are trimming them too late. And you produce a lot of garbage (in 99% of cases you are cloning array with no good reason). I removed excessive cloning; what do you mean by "trimming too late"?
Andrey Lushnikov
Comment 4 2013-01-22 04:03:25 PST
Created attachment 183961 [details] Patch
Pavel Feldman
Comment 5 2013-01-22 05:53:59 PST
> I removed excessive cloning; what do you mean by "trimming too late"? I mean that you trim the data you've just collected. Why collecting it?
Andrey Lushnikov
Comment 6 2013-01-22 06:18:58 PST
Created attachment 183980 [details] Patch
WebKit Review Bot
Comment 7 2013-01-22 06:45:07 PST
Comment on attachment 183980 [details] Patch Clearing flags on attachment: 183980 Committed r140421: <http://trac.webkit.org/changeset/140421>
WebKit Review Bot
Comment 8 2013-01-22 06:45:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.