This functionality had been implemented but was lost due to inaccurate refactoring. So one needs to: - implement this one more time - cover this with a layout test to avoid this in future.
Created attachment 183940 [details] Patch
Comment on attachment 183940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183940&action=review > Source/WebCore/inspector/front-end/TextEditorHighlighter.js:82 > + syntaxTokenHighligh.ranges.sort(comparator); I thought we don't need sorting anymore. > Source/WebCore/inspector/front-end/TextEditorHighlighter.js:85 > + return syntaxTokenHighligh.ranges.slice(0, lastIndex); Tokenizer should not produce these at the first place, you are trimming them too late. And you produce a lot of garbage (in 99% of cases you are cloning array with no good reason).
Comment on attachment 183940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183940&action=review >> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:82 >> + syntaxTokenHighligh.ranges.sort(comparator); > > I thought we don't need sorting anymore. fixed. >> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:85 >> + return syntaxTokenHighligh.ranges.slice(0, lastIndex); > > Tokenizer should not produce these at the first place, you are trimming them too late. And you produce a lot of garbage (in 99% of cases you are cloning array with no good reason). I removed excessive cloning; what do you mean by "trimming too late"?
Created attachment 183961 [details] Patch
> I removed excessive cloning; what do you mean by "trimming too late"? I mean that you trim the data you've just collected. Why collecting it?
Created attachment 183980 [details] Patch
Comment on attachment 183980 [details] Patch Clearing flags on attachment: 183980 Committed r140421: <http://trac.webkit.org/changeset/140421>
All reviewed patches have been landed. Closing bug.