NEW 107525
sheriff-bot should have a suggest-reviewers command
https://bugs.webkit.org/show_bug.cgi?id=107525
Summary sheriff-bot should have a suggest-reviewers command
Eric Seidel (no email)
Reported 2013-01-22 01:54:20 PST
sheriff-bot should have a suggest-reviewers command Just like webkit-patch suggest reviewers, but public in the channel. It makes it trivial when someone shows up asking for a review to teach them how to get one. <eseidel> sheriff-bot: suggest-reviewers 12345 <sheriff-bot> eseidel: Analyzing patch 23243 on bug 12353 for the best possible reviewrs <sheriff-bot> eseidel: Added 5 reviewers to bug 12345: abarth, dpranke, ojan, othermaciej and darin.
Attachments
Zan Dobersek
Comment 1 2013-01-23 03:38:03 PST
AFAIU, this should apply any attachment up for review in the specified bug, run webkit-patch suggest-reviewers, and then CC the suggestions to the bug?
Eric Seidel (no email)
Comment 2 2013-01-23 03:41:33 PST
Correct. As I note in the dependent bug, suggest-reviewers may need a bit of clean-up before it can be made prime-time. Currently it can be a bit over-zealous with its ccing.
Zan Dobersek
Comment 3 2013-01-23 05:23:47 PST
I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command?
Zan Dobersek
Comment 4 2013-01-23 06:13:33 PST
(In reply to comment #3) > I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command? This actually works pretty fast when using a git-svn checkout, so I'm removing this complaint.
Note You need to log in before you can comment on or make changes to this bug.