Bug 107524 – [v8] Convert string conversion calls to one byte versions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dan Carney]

[v8] Convert string conversion calls to one byte versions

[Dan Carney]

Created attachment 183932 [details]
Patch

[Kentaro Hara]

Comment on attachment 183932 [details]
Patch

Looks OK

[WebKit Review Bot]

Comment on attachment 183932 [details]
Patch

Clearing flags on attachment: 183932

Committed r140409: <http://trac.webkit.org/changeset/140409>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Comment on attachment 183932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325
> -        string->WriteAscii(buffer, 0, length, v8StringWriteOptions());
> +        string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions());

What'st he difference between these two calls?  (Just curious.)

[Dan Carney]

Comment on attachment 183932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review

>> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325
>> +        string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions());
> 
> What'st he difference between these two calls?  (Just curious.)

WriteAscii is being removed from the v8 api after WebKit and chrome have removed it.  WriteOneByte takes a uint8_t* as the first argument to indicate that it writes Latin-1.

[Adam Barth]

Makes sense.  Thanks!