Bug 107524 - [v8] Convert string conversion calls to one byte versions
Summary: [v8] Convert string conversion calls to one byte versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 01:52 PST by Dan Carney
Modified: 2013-01-22 11:42 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.86 KB, patch)
2013-01-22 01:54 PST, Dan Carney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2013-01-22 01:52:23 PST
[v8] Convert string conversion calls to one byte versions
Comment 1 Dan Carney 2013-01-22 01:54:18 PST
Created attachment 183932 [details]
Patch
Comment 2 Kentaro Hara 2013-01-22 02:24:21 PST
Comment on attachment 183932 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2013-01-22 04:00:47 PST
Comment on attachment 183932 [details]
Patch

Clearing flags on attachment: 183932

Committed r140409: <http://trac.webkit.org/changeset/140409>
Comment 4 WebKit Review Bot 2013-01-22 04:00:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2013-01-22 09:44:33 PST
Comment on attachment 183932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325
> -        string->WriteAscii(buffer, 0, length, v8StringWriteOptions());
> +        string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions());

What'st he difference between these two calls?  (Just curious.)
Comment 6 Dan Carney 2013-01-22 11:40:40 PST
Comment on attachment 183932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review

>> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325
>> +        string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions());
> 
> What'st he difference between these two calls?  (Just curious.)

WriteAscii is being removed from the v8 api after WebKit and chrome have removed it.  WriteOneByte takes a uint8_t* as the first argument to indicate that it writes Latin-1.
Comment 7 Adam Barth 2013-01-22 11:42:56 PST
Makes sense.  Thanks!