Bug 107520 - [V8] Make an Isolate parameter mandatory in toV8()
Summary: [V8] Make an Isolate parameter mandatory in toV8()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 01:26 PST by Kentaro Hara
Modified: 2013-01-22 01:49 PST (History)
9 users (show)

See Also:

Attachments
Patch (28.81 KB, patch)
2013-01-22 01:28 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-22 01:26:51 PST 
Now it's safe to remove an optional Isolate parameter.
Comment 1 Kentaro Hara 2013-01-22 01:28:05 PST 
Created attachment 183923 [details]
Patch
Comment 2 Adam Barth 2013-01-22 01:29:30 PST 
Comment on attachment 183923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183923&action=review

> Source/WebKit/chromium/src/WebBlob.cpp:66
> -    return toV8(m_private.get(), v8::Handle<v8::Object>());
> +    return toV8(m_private.get(), v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());

So sad.  We shouldn't have added this API.
Comment 3 WebKit Review Bot 2013-01-22 01:49:51 PST 
Comment on attachment 183923 [details]
Patch

Clearing flags on attachment: 183923

Committed r140401: <http://trac.webkit.org/changeset/140401>
Comment 4 WebKit Review Bot 2013-01-22 01:49:55 PST 
All reviewed patches have been landed.  Closing bug.