Bug 107511 – Web Inspector: [Network] CookiesTable refactoring.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Eugene Klyuchnikov]

CookiesTable uses integer indexes as column identifiers. This leads to cryptic code.

Descriptive column identifiers will make code clearer.

Also "addCookiesFolder" replaced with "setCookieFolders" to avoid repetitive "_rebuildTable" invocation.

[Eugene Klyuchnikov]

Created attachment 183902 [details]
Patch

[Andrey Adaikin]

Comment on attachment 183902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183902&action=review

> Source/WebCore/inspector/front-end/CookiesTable.js:43
> +    var columns = {name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, httpOnly: {}, secure: {}};

FYI.
ECMAScript5, 12.6.4 "The for-in Statement":
"The mechanics and order of enumerating the properties (step 6.a in the first algorithm, step 7.a in the second) is not specified."

[Eugene Klyuchnikov]

Comment on attachment 183902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183902&action=review

>> Source/WebCore/inspector/front-end/CookiesTable.js:43
>> +    var columns = {name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, httpOnly: {}, secure: {}};
> 
> FYI.
> ECMAScript5, 12.6.4 "The for-in Statement":
> "The mechanics and order of enumerating the properties (step 6.a in the first algorithm, step 7.a in the second) is not specified."

With explicit keys it will be not worse than with implicit keys (because this is object, not array).
But in general, I agree, we should make column ordering more clear one day.

[WebKit Review Bot]

Comment on attachment 183902 [details]
Patch

Clearing flags on attachment: 183902

Committed r140408: <http://trac.webkit.org/changeset/140408>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.