RESOLVED FIXED 107496
[Refactoring] Remove elementParentStyle from SelectorCheckerContext 
https://bugs.webkit.org/show_bug.cgi?id=107496
Summary [Refactoring] Remove elementParentStyle from SelectorCheckerContext
Takashi Sakamoto
Reported 2013-01-21 20:04:43 PST
Currently elementParentStyle is not used in SelectorChecker and StyleResolver. A parent style was used to cache whether a child of the parent node matches some n-th, first-child, last-child selector. The information was used to check whether a given element can share its sibling element's style or not. However, now the information is stored in a parent element, not style. So we don't need to provide elementParentStyle for SelectorChecker. (c.f. StyleResolver::parentElementPreventsSharing)
Attachments
WIP (5.48 KB, patch)
2013-01-21 20:15 PST, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch (5.49 KB, patch)
2013-01-21 20:18 PST, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1 2013-01-21 20:15:45 PST
Created attachment 183877 [details] WIP
Takashi Sakamoto
Comment 2 2013-01-21 20:18:28 PST
Created attachment 183878 [details] Patch
Takashi Sakamoto
Comment 3 2013-01-21 20:21:27 PST
(In reply to comment #0) > A parent style was used to cache whether a child of the parent node matches some n-th, first-child, last-child selector. The information was used to check whether a given element can share its sibling element's style or not. I mean, childrenAffectedBy bits were moved from RenderStyle to Element, c.f. https://bugs.webkit.org/show_bug.cgi?id=101448
WebKit Review Bot
Comment 4 2013-01-23 02:53:12 PST
Comment on attachment 183878 [details] Patch Clearing flags on attachment: 183878 Committed r140531: <http://trac.webkit.org/changeset/140531>
WebKit Review Bot
Comment 5 2013-01-23 02:53:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.