Bug 107492 – [GTK][MAC] Use CoreFoundation

• Status: NEW
• Component: JavaScriptCore

[Laszlo Gombos]

OS() tests are preferred over a series of PLATFORM() tests for "for low-level services" - see also the discussion at bug 107406.

JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) and PLATFORM(WX), so "PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))" can be replaced by OS(DARWIN) which makes the code more readable as well.

[Laszlo Gombos]

Created attachment 183868 [details]
proposed change

[Alexey Proskuryakov]

Comment on attachment 183868 [details]
proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=183868&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT)
> +        and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is
> +        always true.

Can Gtk port be built on Mac?

[Martin Robinson]

(In reply to comment #2)

> > Source/JavaScriptCore/ChangeLog:8
> > +        JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT)
> > +        and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is
> > +        always true.
> 
> Can Gtk port be built on Mac?

Yes.

[Laszlo Gombos]

(In reply to comment #3)
> (In reply to comment #2)
> 
> > > Source/JavaScriptCore/ChangeLog:8
> > > +        JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT)
> > > +        and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is
> > > +        always true.
> > 
> > Can Gtk port be built on Mac?
> 
> Yes.

I did not know that it is supported. In that case this is probably a performance optimization for the GTK port on Mac. Would it be possible for someone to verify this change for the GTK port on Mac ?

[Laszlo Gombos]

Change the title to better reflect the functional change introduced by the patch. 

I cancel the review until we find someone who can help driving the GTK on MAC discussion.

The larger issue here is the GTK's port policy on using CoreFoundation on OS(DARWIN).

My sense is that reusing the CoreFoundation support from WebKit will make it easier to maintain the GTK MAC port, but I am not the right person to make this determination. Using CoreFoundation support from WebKit - USE(CF) - is the decision that the Qt and WX and CHROMIUM ports made on OS(DARWIN).

[Martin Robinson]

Okay. Assuming that this doesn't change functionality, it seems pretty harmless.

[Laszlo Gombos]

(In reply to comment #6)
> Okay. Assuming that this doesn't change functionality, it seems pretty harmless.

Likely there is a performance benefit for using CF directly.