Bug 107485 - [EFL][WebGL] Enable WebGL layout tests.
Summary: [EFL][WebGL] Enable WebGL layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Kalyan
URL:
Keywords:
Depends on:
Blocks: 104459 104506
  Show dependency treegraph
 
Reported: 2013-01-21 16:19 PST by Kalyan
Modified: 2013-01-22 17:44 PST (History)
9 users (show)

See Also:


Attachments
WIP (3.60 KB, text/plain)
2013-01-22 00:17 PST, Kalyan
no flags Details
patch (3.60 KB, patch)
2013-01-22 00:51 PST, Kalyan
no flags Details | Formatted Diff | Diff
patchv2 (5.52 KB, patch)
2013-01-22 01:28 PST, Kalyan
no flags Details | Formatted Diff | Diff
patchv3 (5.52 KB, patch)
2013-01-22 01:44 PST, Kalyan
no flags Details | Formatted Diff | Diff
patchv4 (5.55 KB, patch)
2013-01-22 07:59 PST, Kalyan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan 2013-01-21 16:19:52 PST
Most of the fixes are in mainline now and layout tests seem quite stable and could be enabled. I will upload an updated testexpectation file.
Comment 1 Kalyan 2013-01-22 00:17:54 PST
Created attachment 183910 [details]
WIP
Comment 2 Kalyan 2013-01-22 00:51:05 PST
Created attachment 183914 [details]
patch

not marking for review or cq yet
Comment 3 Kalyan 2013-01-22 01:28:45 PST
Created attachment 183925 [details]
patchv2
Comment 4 Kalyan 2013-01-22 01:44:26 PST
Created attachment 183929 [details]
patchv3

removed unnecessary new line.
Comment 5 Jussi Kukkonen (jku) 2013-01-22 05:30:44 PST
Comment on attachment 183929 [details]
patchv3

View in context: https://bugs.webkit.org/attachment.cgi?id=183929&action=review

I've run the tests quite extensively and these results are good for me too, with the one exception I mentioned. I didn't check if every flaky one is still flaky but Flakiness deshboard will let us now later anyway.

> LayoutTests/platform/efl/TestExpectations:334
>  # Note webkit.org/b/104506, random crashes

comment is now obsolete

> LayoutTests/platform/efl/TestExpectations:338
>  # Note webkit.org/b/104506, random crashes

this too

> LayoutTests/platform/efl/TestExpectations:342
>  # Note webkit.org/b/104506, random crashes

and this

> LayoutTests/platform/efl/TestExpectations:1730
> +webkit.org/b/106547 fast/canvas/webgl/type-conversion-test.html [ Crash ]

This one actually passes consistently for me.
Comment 6 Kalyan 2013-01-22 07:59:49 PST
Created attachment 183991 [details]
patchv4
Comment 7 Viatcheslav Ostapenko 2013-01-22 09:36:53 PST
(In reply to comment #5)
> (From update of attachment 183929 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183929&action=review
>
> > LayoutTests/platform/efl/TestExpectations:1730
> > +webkit.org/b/106547 fast/canvas/webgl/type-conversion-test.html [ Crash ]
> 
> This one actually passes consistently for me.

There are several different drivers in mesa and it seems it depends on your HW.
For me on Ubuntu 12.04 32bit with mesa sw/llvm rendering it crashes every time.
Comment 8 Laszlo Gombos 2013-01-22 17:12:24 PST
Comment on attachment 183991 [details]
patchv4

r=me.
Comment 9 WebKit Review Bot 2013-01-22 17:44:46 PST
Comment on attachment 183991 [details]
patchv4

Clearing flags on attachment: 183991

Committed r140492: <http://trac.webkit.org/changeset/140492>
Comment 10 WebKit Review Bot 2013-01-22 17:44:51 PST
All reviewed patches have been landed.  Closing bug.