Bug 107473 - Add build flag for Canvas's Path object (disabled by default)
Summary: Add build flag for Canvas's Path object (disabled by default)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 97333
  Show dependency tree / graph
 
Reported: 2013-01-21 13:06 PST by Dirk Schulze
Modified: 2013-01-29 08:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (42.02 KB, patch)
2013-01-21 16:17 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-01-21 13:06:15 PST 
Add build flag for Canvas's Path object (disabled by default)
Comment 1 Dirk Schulze 2013-01-21 16:17:20 PST 
Created attachment 183849 [details]
Patch
Comment 2 Dean Jackson 2013-01-21 17:25:11 PST 
Comment on attachment 183849 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2013-01-21 18:27:49 PST 
Comment on attachment 183849 [details]
Patch

Clearing flags on attachment: 183849

Committed r140377: <http://trac.webkit.org/changeset/140377>
Comment 4 WebKit Review Bot 2013-01-21 18:27:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2013-01-22 02:59:02 PST 
For future reference, the Autotools build system has changed its guidelines about adding features. In short, no need for the configuration flags in configure.ac and Automake conditional checking in Source/WebCore/GNUmakefile.am.
More on this:
http://trac.webkit.org/wiki/AddingFeatures#ActivatingafeatureforAutotoolsbasedports

I've got a change removing these additions in bug #107537.
Comment 6 Dirk Schulze 2013-01-29 08:36:01 PST 
(In reply to comment #5)
> For future reference, the Autotools build system has changed its guidelines about adding features. In short, no need for the configuration flags in configure.ac and Automake conditional checking in Source/WebCore/GNUmakefile.am.
> More on this:
> http://trac.webkit.org/wiki/AddingFeatures#ActivatingafeatureforAutotoolsbasedports
> 
> I've got a change removing these additions in bug #107537.

Ok, thanks!