Bug 107455 – [chromium] move spell checking mocks to TestRunner library

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] move spell checking mocks to TestRunner library

Created attachment 183790 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kent Tamura]

Comment on attachment 183790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183790&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:57
> -    virtual void fillSpellingSuggestionList(const WebKit::WebString& word, WebKit::WebVector<WebKit::WebString>* suggestions) = 0;
> +    virtual void fillSpellingSuggestionList(const WebKit::WebString&, WebKit::WebVector<WebKit::WebString>*) { }

nit: You don't need to remove the argument names.  "word" "suggestions" have additional information.

> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:200
> +    , m_spellcheck(new SpellCheckClient)
>  {
>  }
>  
>  WebTestProxyBase::~WebTestProxyBase()
>  {
> +    delete m_spellcheck;

We should avoid manual memory management.  Can you use OwnPtr<>?

Won't I get an unused arguments warning when I don't remove the names?

I can't used OwnPtr in a public API header, and I can't use WebPrivatePtr since the TestRunner's implementation doesn't define WEBKIT_IMPLEMENTATION. Therefore, we use raw pointers, see e.g. WebTestInterfaces

[Kent Tamura]

Ah, I understand.

[WebKit Review Bot]

Comment on attachment 183790 [details]
Patch

Clearing flags on attachment: 183790

Committed r140396: <http://trac.webkit.org/changeset/140396>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.