Bug 107452 - Web Inspector: reuse JS heap profiler UI for native heap graph representaion
Summary: Web Inspector: reuse JS heap profiler UI for native heap graph representaion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 08:00 PST by Yury Semikhatsky
Modified: 2013-01-22 00:11 PST (History)
9 users (show)

See Also:

Attachments
Patch (27.63 KB, patch)
2013-01-21 08:08 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (26.74 KB, patch)
2013-01-21 08:09 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (26.75 KB, patch)
2013-01-21 08:11 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-01-21 08:00:59 PST 
We can view native heap graph using the same UI as we employ for JS heap snapshots. Assuming the memory instrumentation provides enough named entries it may be quite useful for analyzing WebKit native memory.
Comment 1 Yury Semikhatsky 2013-01-21 08:08:11 PST 
Created attachment 183786 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-21 08:09:20 PST 
Created attachment 183787 [details]
Patch
Comment 3 Yury Semikhatsky 2013-01-21 08:11:50 PST 
Created attachment 183788 [details]
Patch
Comment 4 Ilya Tikhonovsky 2013-01-21 08:17:59 PST 
Comment on attachment 183788 [details]
Patch

lgtm
Comment 5 WebKit Review Bot 2013-01-22 00:11:42 PST 
Comment on attachment 183788 [details]
Patch

Clearing flags on attachment: 183788

Committed r140390: <http://trac.webkit.org/changeset/140390>
Comment 6 WebKit Review Bot 2013-01-22 00:11:46 PST 
All reviewed patches have been landed.  Closing bug.