WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
107447
[Qt] Fix the QtTestBrowser build if older QtWebKit is installed into system path
https://bugs.webkit.org/show_bug.cgi?id=107447
Summary
[Qt] Fix the QtTestBrowser build if older QtWebKit is installed into system path
Csaba Osztrogonác
Reported
2013-01-21 06:40:51 PST
QtTestBrowser build is now broken if you try to build trunk WebKit with Qt 5.0 release version. (which contains an older QtWebKit) (revealed by
https://trac.webkit.org/changeset/139437
) build log (
r140317
): --------------------- /home/webkit/WebKit/Tools/QtTestBrowser/launcherwindow.cpp: In member function 'void LauncherWindow::applyPrefs()': /home/webkit/WebKit/Tools/QtTestBrowser/launcherwindow.cpp:220:59: error: 'WebAudioEnabled' is not a member of 'QWebSettings' /home/webkit/WebKit/Tools/QtTestBrowser/launcherwindow.cpp: In member function 'void LauncherWindow::toggleWebAudio(bool)': /home/webkit/WebKit/Tools/QtTestBrowser/launcherwindow.cpp:878:38: error: 'WebAudioEnabled' is not a member of 'QWebSettings' The build failure is occured, because Tools/QtTestBrowser/launcherwindow.h includes qwebsettings.h inside release Qt 5.0 and not qwebsettings.h in WebKit trunk. I think it is a general problem, we need a way to disable QtWebKit includes/libararies for trunk WebKit build.
Attachments
Add attachment
proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1
2014-02-03 03:24:24 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug