Bug 107436 - [GTK] Disable support for unprefixed CSS animations, transitions, transforms in release builds
Summary: [GTK] Disable support for unprefixed CSS animations, transitions, transforms ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 03:29 PST by Zan Dobersek
Modified: 2013-01-22 03:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2013-01-21 03:31 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-01-21 03:29:33 PST 
[GTK] Disable support for unprefixed CSS animations, transitions, transforms in release builds
Comment 1 Zan Dobersek 2013-01-21 03:31:23 PST 
Created attachment 183749 [details]
Patch
Comment 2 Hajime Morrita 2013-01-22 02:51:34 PST 
Don't you need any TestExpectation change?
Comment 3 Zan Dobersek 2013-01-22 03:25:00 PST 
(In reply to comment #2)
> Don't you need any TestExpectation change?

No, layout tests are not (usually) run in release builds. In development builds (what developers and the buildbots are using), the value of each feature define in the changed file is overridden with the value that's listed in FeatureList.pm. That means that the ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED feature define is assigned 1 as the value in these builds.

TL;DR: No, the buildbots are not affected, just the release builds.
Comment 4 Zan Dobersek 2013-01-22 03:43:05 PST 
Comment on attachment 183749 [details]
Patch

Clearing flags on attachment: 183749

Committed r140407: <http://trac.webkit.org/changeset/140407>
Comment 5 Zan Dobersek 2013-01-22 03:43:10 PST 
All reviewed patches have been landed.  Closing bug.