Bug 107432 - [Soup] Use synchronous calls to close completely processed streams
Summary: [Soup] Use synchronous calls to close completely processed streams
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 107439
  Show dependency tree / graph
 
Reported: 2013-01-21 02:01 PST by Sergio Villar Senin
Modified: 2013-02-19 07:17 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2013-01-21 02:10 PST, Sergio Villar Senin 		mrobinson: review+
svillar: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-01-21 02:01:04 PST 
[Soup] Use synchronous calls to close completely processed streams
Comment 1 Sergio Villar Senin 2013-01-21 02:10:10 PST 
Created attachment 183739 [details]
Patch
Comment 2 Sergio Villar Senin 2013-01-21 05:09:10 PST 
We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped...
Comment 3 Martin Robinson 2013-01-21 08:09:32 PST 
Comment on attachment 183739 [details]
Patch

Great! Might be good to get Dan to look at this one too.
Comment 4 Dan Winship 2013-01-21 08:10:33 PST 
(In reply to comment #2)
> We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped...

I wouldn't recommend that, because if something was holding a ref on the stream for a while for some reason after we were done reading, that would prevent the connection from being reused for another request.
Comment 5 Sergio Villar Senin 2013-01-21 08:27:48 PST 
(In reply to comment #3)
> (From update of attachment 183739 [details])
> Great! Might be good to get Dan to look at this one too.

Cool, I'll wait until we have a clear idea about what triggers the crashes I'm seeing in bug 107439 tough.
Comment 6 Sergio Villar Senin 2013-01-21 08:28:26 PST 
Comment on attachment 183739 [details]
Patch

Do not land this automatically, just in case.
Comment 7 Sergio Villar Senin 2013-02-19 07:17:52 PST 
Committed r143329: <http://trac.webkit.org/changeset/143329>