Bug 107419 – Web Inspector: Do not dispatch mousemove when emulating touch event and no touch is active

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

If the point of emulate-touch-events is to let website developers verify their site works OK with a touchscreen, then it's important that we don't dispatch any mouse events.

At the moment it looks like we still get mousemove events when moving the mouse cursor (tested at http://www.rbyers.net/eventTest.html).  This can trigger, for example, hover menus that rely on mousemove/mouseover events, so may be impossible to trigger on a true touchscreen device, therefore leading a developer to think their site is fine when it's not.

Upstreaming https://code.google.com/p/chromium/issues/detail?id=168399

[Alexander Pavlov (apavlov)]

Created attachment 183717 [details]
Patch

[WebKit Review Bot]

Comment on attachment 183717 [details]
Patch

Rejecting attachment 183717 [details] from commit-queue.

New failing tests:
fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html
fast/forms/range/slider-delete-while-dragging-thumb.html
fast/forms/datalist/update-range-with-datalist.html
fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/forms/number/number-spinbutton-state.html
fast/forms/number/number-spinbutton-change-and-input-events.html
fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
fast/lists/drag-into-marker.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html
fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html
fast/events/touch/gesture/gesture-dblclick.html
fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html
fast/forms/range/slider-mouse-events.html
fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html
fast/events/touch/emulate-touch-events.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html
fast/forms/number/number-spinbutton-click-in-iframe.html
fast/events/touch/page-scaled-touch-gesture-click.html
fast/forms/number/number-large-padding.html
fast/events/touch/gesture/gesture-click.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html
fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html
fast/loader/javascript-url-in-object.html
fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html
fast/forms/number/number-spinbutton-capturing.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
Full output: http://queues.webkit.org/results/15978916

[Alexander Pavlov (apavlov)]

Committed r140311: <http://trac.webkit.org/changeset/140311>

[WebKit Review Bot]

Re-opened since this is blocked by bug 107431

[Alexander Pavlov (apavlov)]

Created attachment 183735 [details]
For EWS

[Alexander Pavlov (apavlov)]

Created attachment 183738 [details]
For EWS

[Alexander Pavlov (apavlov)]

Created attachment 183753 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 183753 [details]
Patch for landing

Clearing flags on attachment: 183753

Committed r140321: <http://trac.webkit.org/changeset/140321>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.