Bug 107405 - Remove support getting per-resource callbacks in the UIProcess
Summary: Remove support getting per-resource callbacks in the UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 107421 107417
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-20 15:07 PST by Sam Weinig
Modified: 2013-02-02 17:14 PST (History)
14 users (show)

See Also:

Attachments
Patch (27.21 KB, patch)
2013-01-20 15:10 PST, Sam Weinig 		andersca: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
EFL, GTK & Qt build fixes after r140285. (2.59 KB, patch)
2013-01-20 20:43 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-01-20 15:07:12 PST 
Remove support getting per-resource callbacks in the UIProcess
Comment 1 Sam Weinig 2013-01-20 15:10:29 PST 
Created attachment 183689 [details]
Patch
Comment 2 EFL EWS Bot 2013-01-20 15:14:58 PST 
Comment on attachment 183689 [details]
Patch

Attachment 183689 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15974781
Comment 3 Early Warning System Bot 2013-01-20 15:16:48 PST 
Comment on attachment 183689 [details]
Patch

Attachment 183689 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16011042
Comment 4 Anders Carlsson 2013-01-20 15:20:47 PST 
Comment on attachment 183689 [details]
Patch

r=me assuming it doesn't break the nightly builds.
Comment 5 Sam Weinig 2013-01-20 17:02:59 PST 
Committed r140285: <http://trac.webkit.org/changeset/140285>
Comment 6 Viatcheslav Ostapenko 2013-01-20 20:42:02 PST 
Reopen because of build breaks.
Comment 7 Viatcheslav Ostapenko 2013-01-20 20:43:13 PST 
Created attachment 183700 [details]
EFL, GTK & Qt build fixes after r140285.
Comment 8 WebKit Review Bot 2013-01-20 21:43:38 PST 
Comment on attachment 183700 [details]
EFL, GTK & Qt build fixes after r140285.

Clearing flags on attachment: 183700

Committed r140294: <http://trac.webkit.org/changeset/140294>
Comment 9 Thiago Marcos P. Santos 2013-01-20 22:13:53 PST 
(In reply to comment #7)
> Created an attachment (id=183700) [details]
> EFL, GTK & Qt build fixes after r140285.

Thanks for addressing the build breakage, but I'm afraid this is going to be more than just a buildsystem fix.
Comment 10 Carlos Garcia Campos 2013-01-21 08:21:26 PST 
(In reply to comment #8)
> (From update of attachment 183700 [details])
> Clearing flags on attachment: 183700
> 
> Committed r140294: <http://trac.webkit.org/changeset/140294>

This is not a build fix, it removes public headers from the WebKit2 GTK+ API.
Comment 11 Carlos Garcia Campos 2013-01-21 08:25:22 PST 
(In reply to comment #10)
> (In reply to comment #8)
> > (From update of attachment 183700 [details] [details])
> > Clearing flags on attachment: 183700
> > 
> > Committed r140294: <http://trac.webkit.org/changeset/140294>
> 
> This is not a build fix, it removes public headers from the WebKit2 GTK+ API.

Sorry, I misread the patch, it doesn't remove any patch from API/gtk dir. I still wonder how can this build, since GTK+ depends on WKPageResourceLoadClient. I'll look at it in detail.