Bug 107403 - [BlackBerry] Improve Fatfinger phase.
Summary: [BlackBerry] Improve Fatfinger phase.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-20 12:39 PST by Tiancheng Jiang
Modified: 2013-06-17 11:06 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.40 KB, patch)
2013-01-20 13:11 PST, Tiancheng Jiang 		no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2013-05-14 14:41 PDT, Tiancheng Jiang 		no flags Details | Formatted Diff | Diff
Patch (4.08 KB, patch)
2013-05-24 08:34 PDT, Tiancheng Jiang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tiancheng Jiang 2013-01-20 12:39:54 PST 
Treat ClickableByDefault and MadeClickableByTheWebpage elements as same category. Avoid unnecessary nodes check step.
Comment 1 Tiancheng Jiang 2013-01-20 13:11:25 PST 
Created attachment 183683 [details]
Patch
Comment 2 Rob Buis 2013-01-20 14:52:56 PST 
Comment on attachment 183683 [details]
Patch

LGTM, nice to see some code removal.
Comment 3 WebKit Review Bot 2013-01-20 14:57:17 PST 
Comment on attachment 183683 [details]
Patch

Clearing flags on attachment: 183683

Committed r140282: <http://trac.webkit.org/changeset/140282>
Comment 4 WebKit Review Bot 2013-01-20 14:57:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Antonio Gomes 2013-01-20 20:25:40 PST 
This code was all added with a reason: it fixed many bugs. you removed it without any justification.
Comment 6 Tiancheng Jiang 2013-05-14 14:41:37 PDT 
Reopening to attach new patch.
Comment 7 Tiancheng Jiang 2013-05-14 14:41:40 PDT 
Created attachment 201761 [details]
Patch
Comment 8 Rob Buis 2013-05-14 14:44:41 PDT 
Comment on attachment 201761 [details]
Patch

Ok.
Comment 9 WebKit Commit Bot 2013-05-14 15:39:48 PDT 
Comment on attachment 201761 [details]
Patch

Clearing flags on attachment: 201761

Committed r150091: <http://trac.webkit.org/changeset/150091>
Comment 10 WebKit Commit Bot 2013-05-14 15:39:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Tiancheng Jiang 2013-05-24 08:34:38 PDT 
Reopening to attach new patch.
Comment 12 Tiancheng Jiang 2013-05-24 08:34:41 PDT 
Created attachment 202823 [details]
Patch
Comment 13 Antonio Gomes 2013-05-24 14:03:01 PDT 
Comment on attachment 202823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review

> Source/WebKit/blackberry/ChangeLog:9
> +        Cache the FatFinger text result for later use in TouchEventHandler.

use it later when? where? what does it fix?
Comment 14 Tiancheng Jiang 2013-05-24 14:17:54 PDT 
Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now?

(In reply to comment #13)
> (From update of attachment 202823 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review
> 
> > Source/WebKit/blackberry/ChangeLog:9
> > +        Cache the FatFinger text result for later use in TouchEventHandler.
> 
> use it later when? where? what does it fix?
Comment 15 Rob Buis 2013-06-14 12:40:41 PDT 
(In reply to comment #14)
> Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now?

Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed.
Comment 16 Antonio Gomes 2013-06-14 15:48:42 PDT 
(In reply to comment #15)
> (In reply to comment #14)
> > Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now?
> 
> Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed.

I have nothing against it, but if it is not needed so far, I would not commit it. If you guys want to go ahead, I am fine with it.
Comment 17 Rob Buis 2013-06-17 10:45:32 PDT 
Comment on attachment 202823 [details]
Patch

Okay.
Comment 18 WebKit Commit Bot 2013-06-17 11:06:44 PDT 
Comment on attachment 202823 [details]
Patch

Clearing flags on attachment: 202823

Committed r151648: <http://trac.webkit.org/changeset/151648>
Comment 19 WebKit Commit Bot 2013-06-17 11:06:48 PDT 
All reviewed patches have been landed.  Closing bug.