107399 – [SVG2] Refactor SVGTextContentElement to inherit from SVGStyledTransformableElement

NEW 107399

[SVG2] Refactor SVGTextContentElement to inherit from SVGStyledTransformableElement

https://bugs.webkit.org/show_bug.cgi?id=107399

Summary [SVG2] Refactor SVGTextContentElement to inherit from SVGStyledTransformableE...

Dirk Schulze

Reported 2013-01-20 07:40:03 PST

Refactor SVGTextContentElement to inherit from SVGStyledTransformableElement (which will get SVGGraphicsElement after this refactoring). See specification.

Attachments
Patch (10.78 KB, patch) 2013-01-20 08:10 PST, Dirk Schulze	buildbot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2013-01-20 08:10:12 PST

Created attachment 183673 [details] Patch I just save my work here for now. All tests seem to pass with the exception of the text selection tests (like always :( ).

Build Bot

Comment 2 2013-01-20 18:19:04 PST

Comment on attachment 183673 [details] Patch Attachment 183673 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15976818 New failing tests: svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg svg/text/select-x-list-with-tspans-4.svg svg/text/select-textLength-spacing-squeeze-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg svg/text/select-x-list-3.svg svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg svg/text/select-textLength-spacing-squeeze-1.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg svg/text/selection-doubleclick.svg svg/text/select-x-list-with-tspans-3.svg svg/text/select-textLength-spacing-stretch-1.svg svg/text/select-x-list-2.svg svg/text/select-x-list-with-tspans-2.svg svg/text/select-textLength-spacing-stretch-2.svg svg/text/select-x-list-with-tspans-1.svg svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg svg/text/select-textLength-spacing-squeeze-2.svg svg/text/select-x-list-4.svg svg/text/select-x-list-1.svg svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg svg/text/select-textLength-spacing-stretch-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg svg/text/select-textLength-spacing-squeeze-4.svg svg/text/select-textLength-spacing-stretch-4.svg

WebKit Review Bot

Comment 3 2013-01-21 14:42:24 PST

Comment on attachment 183673 [details] Patch Attachment 183673 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16037236 New failing tests: svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg svg/text/select-x-list-with-tspans-4.svg svg/text/select-textLength-spacing-squeeze-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg svg/text/select-x-list-3.svg svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg svg/text/select-textLength-spacing-squeeze-1.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg svg/text/selection-doubleclick.svg svg/text/select-x-list-with-tspans-3.svg svg/text/select-textLength-spacing-stretch-1.svg svg/text/select-x-list-2.svg svg/text/select-x-list-with-tspans-2.svg svg/text/select-textLength-spacing-stretch-2.svg svg/text/select-x-list-with-tspans-1.svg svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg svg/text/select-textLength-spacing-squeeze-2.svg svg/text/select-x-list-4.svg svg/text/select-x-list-1.svg svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg svg/text/select-textLength-spacing-stretch-3.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg svg/text/select-textLength-spacing-squeeze-4.svg svg/text/select-textLength-spacing-stretch-4.svg

Note You need to log in before you can comment on or make changes to this bug.