Bug 107393 - [SVG2] Refactor SVGSVGElement to inherit from SVGStyledTransformableElement
Summary: [SVG2] Refactor SVGSVGElement to inherit from SVGStyledTransformableElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-19 21:08 PST by Philip Rogers
Modified: 2013-01-19 22:34 PST (History)
8 users (show)

See Also:

Attachments
First pass (7.94 KB, patch)
2013-01-19 21:52 PST, Philip Rogers 		no flags Details | Formatted Diff | Diff
Fix merge conflict (7.94 KB, patch)
2013-01-19 22:01 PST, Philip Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2013-01-19 21:08:28 PST 
SVG2 updates the class hierarchy so SVGSVGElement inherits from SVGGraphicsElement:
https://svgwg.org/svg2-draft/single-page.html#struct-InterfaceSVGSVGElement

We don't have the SVGGraphicsElement yet but it will eventually replace SVGStyledTransformableElement.

A comparison of SVG 1.1 and SVG 2:
https://docs.google.com/a/google.com/drawings/d/1DjmqGOk71JATh5ysZtnFe0Nxvox-g6mZ-M02jLA9aOc/edit?pli=1
Comment 1 Philip Rogers 2013-01-19 21:52:00 PST 
Created attachment 183656 [details]
First pass
Comment 2 Philip Rogers 2013-01-19 22:01:17 PST 
Created attachment 183657 [details]
Fix merge conflict
Comment 3 Dirk Schulze 2013-01-19 22:16:15 PST 
Comment on attachment 183657 [details]
Fix merge conflict

LGTM. r=me.
Comment 4 WebKit Review Bot 2013-01-19 22:33:56 PST 
Comment on attachment 183657 [details]
Fix merge conflict

Clearing flags on attachment: 183657

Committed r140267: <http://trac.webkit.org/changeset/140267>
Comment 5 WebKit Review Bot 2013-01-19 22:34:00 PST 
All reviewed patches have been landed.  Closing bug.