RESOLVED FIXED 107391
Fix disambiguation popup for new-style page scale 
https://bugs.webkit.org/show_bug.cgi?id=107391
Summary Fix disambiguation popup for new-style page scale
Tien-Ren Chen
Reported Sunday, January 20, 2013 3:35:58 AM UTC
Fix disambiguation popup for new-style page scale
Attachments
Patch (8.67 KB, patch)
2013-01-19 19:41 PST, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (28.23 KB, patch)
2013-01-22 16:46 PST, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2013-01-22 16:50 PST, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (7.85 KB, patch)
2013-01-28 21:29 PST, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 Sunday, January 20, 2013 3:41:03 AM UTC
Created attachment 183653 [details] Patch
WebKit Review Bot
Comment 2 Sunday, January 20, 2013 3:43:59 AM UTC
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 Sunday, January 20, 2013 3:50:02 AM UTC
Comment on attachment 183653 [details] Patch Attachment 183653 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15970434
Peter Beverloo (cr-android ews)
Comment 4 Sunday, January 20, 2013 4:03:59 AM UTC
Comment on attachment 183653 [details] Patch Attachment 183653 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15972426
Adam Barth
Comment 5 Sunday, January 20, 2013 8:28:00 AM UTC
Comment on attachment 183653 [details] Patch Can we test this change? Also, it looks like you're failing the Chromium EWS bots.
Tien-Ren Chen
Comment 6 Wednesday, January 23, 2013 12:46:43 AM UTC
Created attachment 184077 [details] Patch
Tien-Ren Chen
Comment 7 Wednesday, January 23, 2013 12:50:42 AM UTC
Created attachment 184081 [details] Patch
Tien-Ren Chen
Comment 8 Tuesday, January 29, 2013 5:29:05 AM UTC
Created attachment 185148 [details] Patch
Tien-Ren Chen
Comment 9 Tuesday, January 29, 2013 5:29:45 AM UTC
Changes from last patch: * Added WebFrameTest.DisambiguationPopupPageScale unit test * Rebased
Adam Barth
Comment 10 Tuesday, January 29, 2013 5:32:51 AM UTC
Comment on attachment 185148 [details] Patch Thanks for the test.
WebKit Review Bot
Comment 11 Tuesday, January 29, 2013 7:30:58 AM UTC
Comment on attachment 185148 [details] Patch Clearing flags on attachment: 185148 Committed r141062: <http://trac.webkit.org/changeset/141062>
WebKit Review Bot
Comment 12 Tuesday, January 29, 2013 7:31:03 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.