Bug 107391 - Fix disambiguation popup for new-style page scale
Summary: Fix disambiguation popup for new-style page scale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 107424
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-19 19:35 PST by Tien-Ren Chen
Modified: 2013-01-28 23:31 PST (History)
12 users (show)

See Also:


Attachments
Patch (8.67 KB, patch)
2013-01-19 19:41 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (28.23 KB, patch)
2013-01-22 16:46 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2013-01-22 16:50 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (7.85 KB, patch)
2013-01-28 21:29 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2013-01-19 19:35:58 PST
Fix disambiguation popup for new-style page scale
Comment 1 Tien-Ren Chen 2013-01-19 19:41:03 PST
Created attachment 183653 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-19 19:43:59 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-01-19 19:50:02 PST
Comment on attachment 183653 [details]
Patch

Attachment 183653 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15970434
Comment 4 Peter Beverloo (cr-android ews) 2013-01-19 20:03:59 PST
Comment on attachment 183653 [details]
Patch

Attachment 183653 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15972426
Comment 5 Adam Barth 2013-01-20 00:28:00 PST
Comment on attachment 183653 [details]
Patch

Can we test this change?  Also, it looks like you're failing the Chromium EWS bots.
Comment 6 Tien-Ren Chen 2013-01-22 16:46:43 PST
Created attachment 184077 [details]
Patch
Comment 7 Tien-Ren Chen 2013-01-22 16:50:42 PST
Created attachment 184081 [details]
Patch
Comment 8 Tien-Ren Chen 2013-01-28 21:29:05 PST
Created attachment 185148 [details]
Patch
Comment 9 Tien-Ren Chen 2013-01-28 21:29:45 PST
Changes from last patch:
* Added WebFrameTest.DisambiguationPopupPageScale unit test
* Rebased
Comment 10 Adam Barth 2013-01-28 21:32:51 PST
Comment on attachment 185148 [details]
Patch

Thanks for the test.
Comment 11 WebKit Review Bot 2013-01-28 23:30:58 PST
Comment on attachment 185148 [details]
Patch

Clearing flags on attachment: 185148

Committed r141062: <http://trac.webkit.org/changeset/141062>
Comment 12 WebKit Review Bot 2013-01-28 23:31:03 PST
All reviewed patches have been landed.  Closing bug.