It appears that the master.cfg and committer_auth.py only import webkitpy.common.net.htdigestparser and webkitpy.common.config.build from webkitpy, both of which are never used elsewhere in webkitpy. So we can just move these files into BuildSlaveSupport and remove the entire dependency.
Created attachment 184146 [details] Removes the dependency
<rdar://problem/13068009>
Comment on attachment 184146 [details] Removes the dependency View in context: https://bugs.webkit.org/attachment.cgi?id=184146&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:89 > +# FIXME: We should run this file as part of test-rm . > +# Unfortunately test-rm currently requires that unittests > +# be located in a directory with a valid module name. > +# 'build.webkit.org-config' is not a valid module name (due to '.' and '-') > +# so for now this is a stand-alone test harness. What is test-rm?
(In reply to comment #3) > (From update of attachment 184146 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184146&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:89 > > +# FIXME: We should run this file as part of test-rm . > > +# Unfortunately test-rm currently requires that unittests > > +# be located in a directory with a valid module name. > > +# 'build.webkit.org-config' is not a valid module name (due to '.' and '-') > > +# so for now this is a stand-alone test harness. > > What is test-rm? I don't know. I just copy & pasted that from mastercfg_unittest.py.
Created attachment 185917 [details] Updated for ToT
Comment on attachment 185917 [details] Updated for ToT LGTM.
Committed r141530: <http://trac.webkit.org/changeset/141530>