PLATFORM(WIN) PLATFORM(CHROMIUM) and PLATFORM(QT) are mutually exclusive - only one of them can be true. In a few places we have tests like "PLATFORM(WIN) && !PLATFORM(CHROMIUM) && !PLATFORM(QT)". This is probably a left over from the times when PLATFORM(WIN) use to be OS(WIN).
Created attachment 183605 [details] proposed change
Comment on attachment 183605 [details] proposed change Because PLATFORM(WIN) means AppleWin?
(In reply to comment #2) > (From update of attachment 183605 [details]) > Because PLATFORM(WIN) means AppleWin? Yes, indeed.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 183605 [details] [details]) > > Because PLATFORM(WIN) means AppleWin? > > Yes, indeed. These PLATFORM() macros are setup in Platform.h and from the definition it is clear that there are mutually exclusive. #if defined(BUILDING_CHROMIUM__) #define WTF_PLATFORM_CHROMIUM 1 #elif defined(BUILDING_QT__) #define WTF_PLATFORM_QT 1 #elif defined(BUILDING_WX__) #define WTF_PLATFORM_WX 1 #elif defined(BUILDING_EFL__) #define WTF_PLATFORM_EFL 1 #elif defined(BUILDING_GTK__) #define WTF_PLATFORM_GTK 1 #elif defined(BUILDING_BLACKBERRY__) #define WTF_PLATFORM_BLACKBERRY 1 #elif OS(DARWIN) #define WTF_PLATFORM_MAC 1 #elif OS(WINDOWS) #define WTF_PLATFORM_WIN 1 #endif
Comment on attachment 183605 [details] proposed change OK. One of these years we should rename PLATFORM(MAC) and PLATFORM(WIN) to PLATFORM(APPLE_MAC) and APPLE_WIN to end the confusion.
Comment on attachment 183605 [details] proposed change Clearing flags on attachment: 183605 Committed r140238: <http://trac.webkit.org/changeset/140238>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > OK. One of these years we should rename PLATFORM(MAC) and PLATFORM(WIN) to PLATFORM(APPLE_MAC) and APPLE_WIN to end the confusion. Renaming is fine, but even though they seem different to you, I don’t think that most people would understand APPLE_MAC as distinct from MAC, so I think we have to think more on how to name.