Bug 107339 - Event target rects on the top level document shouldn't be clipped.
Summary: Event target rects on the top level document shouldn't be clipped.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Reported: 2013-01-18 16:25 PST by Levi Weintraub
Modified: 2013-01-21 17:40 PST (History)
6 users (show)

See Also:

Patch (10.58 KB, patch)
2013-01-18 16:44 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2013-01-18 16:25:03 PST
We were using the clippedOverflowRectForRepaint for (touch) event listeners on the Document/DOMWindow, but that's only correct for child documents, as the top-level view is clipped to the viewport. Instead we should use the documentRect.
Comment 1 Levi Weintraub 2013-01-18 16:44:13 PST
Created attachment 183574 [details]
Comment 2 WebKit Review Bot 2013-01-21 16:33:25 PST
Comment on attachment 183574 [details]

Clearing flags on attachment: 183574

Committed r140370: <http://trac.webkit.org/changeset/140370>
Comment 3 WebKit Review Bot 2013-01-21 16:33:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Nico Weber 2013-01-21 17:36:27 PST
platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html started failing on chromium/mac after this CL: http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/32187/steps/layout-test/logs/stdio

Is this intentional?
Comment 5 Levi Weintraub 2013-01-21 17:37:30 PST
Taking a look...
Comment 6 Levi Weintraub 2013-01-21 17:40:53 PST
Just needed new baselines. Committed r140374: <http://trac.webkit.org/changeset/140374>