WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
107329
Chromium WebKit API should use updateLayout() rather than updateLayoutIgnorePendingStylesheets()
https://bugs.webkit.org/show_bug.cgi?id=107329
Summary
Chromium WebKit API should use updateLayout() rather than updateLayoutIgnoreP...
Ilya Sherman
Reported
2013-01-18 14:50:21 PST
Chromium's WebNode implementation calls updateLayoutIgnorePendingStylesheets() in a couple of places in its implementation. These should be updateLayout() instead, to prevent issues like [
https://code.google.com/p/chromium/issues/detail?id=167083
], where a CSS transition animation is being incorrectly triggered due to Chrome Autofill calling into these functions.
Attachments
Patch
(1.59 KB, patch)
2013-01-18 14:52 PST
,
Ilya Sherman
jamesr
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Sherman
Comment 1
2013-01-18 14:52:06 PST
Created
attachment 183551
[details]
Patch
James Robinson
Comment 2
2013-01-18 15:00:54 PST
Comment on
attachment 183551
[details]
Patch I don't think this patch does what you think it does. All (nearly all?) dom accessors that trigger layout use the ..IgnorePendingStylesheets() version. If you decide you do want a behavior change, it should be covered in webkit_unit_tests
Ilya Sherman
Comment 3
2013-01-18 15:07:43 PST
(In reply to
comment #2
)
> (From update of
attachment 183551
[details]
) > I don't think this patch does what you think it does. All (nearly all?) dom accessors that trigger layout use the ..IgnorePendingStylesheets() version.
Hmm, ok. There's a big scary comment by ...IgnorePendingStylesheets() that made me think using it was probably wrong. Guess I'll send the original Chromium bug back to the un-owned pool, as I don't know the rendering system well enough.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug