WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107321
Harden ArithDiv of integers fix-up by inserting Int32ToDouble node directly
https://bugs.webkit.org/show_bug.cgi?id=107321
Summary
Harden ArithDiv of integers fix-up by inserting Int32ToDouble node directly
Michael Saboff
Reported
2013-01-18 13:39:32 PST
For non-X86 platforms, we perform integer division by converting the integer arguments to doubles, perform the division and then convert the result back to an Int32. The insertion of the conversion nodes is done by the fixup phase. Currently the code uses fixDoubleEdge() for the inputs, but we have already performed a check of the int-ness of the arguments and this is really a special case. Therefore it makes more sense to do the Int32ToDouble node insertion without further checks of the child nodes.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2013-01-18 13:40:53 PST
From <
rdar://problem/12645632
>
Michael Saboff
Comment 2
2013-01-18 13:46:30 PST
Committed
r140203
: <
http://trac.webkit.org/changeset/140203
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug