Bug 107313 - Objective-C API: Update documentation for JSValue and JSContext
Summary: Objective-C API: Update documentation for JSValue and JSContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 12:41 PST by Mark Hahnenberg
Modified: 2013-01-18 12:56 PST (History)
0 users

See Also:

Attachments
Patch (3.87 KB, patch)
2013-01-18 12:48 PST, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-01-18 12:41:55 PST 
After changing the semantics of object lifetime we need to update the API documentation to reflect the new semantics. This will primarily affect APIJSValue.h and JSContext.h.
Comment 1 Mark Hahnenberg 2013-01-18 12:48:46 PST 
Created attachment 183531 [details]
Patch
Comment 2 Geoffrey Garen 2013-01-18 12:50:30 PST 
Comment on attachment 183531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183531&action=review

> Source/JavaScriptCore/API/JSContext.h:39
> +// will become invalid unless it has been previously retained.

s/will become invalid/will be deallocated/
Comment 3 Mark Hahnenberg 2013-01-18 12:56:04 PST 
Committed r140197: <http://trac.webkit.org/changeset/140197>