Bug 107303 - Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
Summary: Web Inspector: Native Memory Instrumentation: provide edge names and class na...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 107254 107278
  Show dependency treegraph
 
Reported: 2013-01-18 10:45 PST by Ilya Tikhonovsky
Modified: 2013-02-01 07:34 PST (History)
11 users (show)

See Also:


Attachments
Patch (9.48 KB, patch)
2013-01-18 10:52 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2013-01-19 04:21 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-01-18 10:45:33 PST
I think ValueType[] would be good class name for the containers internal data buffers.
I can eval the actual class name for ValueType but it will gives us nothing new because the same class name is a part of the container class name.
Like WebCore::HashMap<String>

Also this class name may significantly increase the footprint of the binary.
Comment 1 Ilya Tikhonovsky 2013-01-18 10:52:02 PST
Created attachment 183504 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-01-19 04:21:28 PST
Created attachment 183620 [details]
Patch
Comment 3 Ilya Tikhonovsky 2013-02-01 07:34:25 PST
Committed r141591: <http://trac.webkit.org/changeset/141591>