Bug 107291 - Web Inspector: data grid resize is slow
Summary: Web Inspector: data grid resize is slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 09:05 PST by Andrey Kosyakov
Modified: 2013-01-21 08:09 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2013-01-18 09:07 PST, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2013-01-18 09:05:00 PST
0. Open inspector
1. Switch to network panel (or Resources -> Cookies)
2. Quickly drag a resizer in the table
3. Observe update lags considerably
Comment 1 Andrey Kosyakov 2013-01-18 09:07:20 PST
Created attachment 183475 [details]
Patch
Comment 2 Pavel Feldman 2013-01-20 23:22:42 PST
Comment on attachment 183475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183475&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:688
> +                    resizer._position = left;

Resizers are cached and I don't see where this property is reset. Do you want to split this loop into two loops? First would measure, second would apply.
Comment 3 Andrey Kosyakov 2013-01-21 00:54:29 PST
Comment on attachment 183475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183475&action=review

>> Source/WebCore/inspector/front-end/DataGrid.js:688
>> +                    resizer._position = left;
> 
> Resizers are cached and I don't see where this property is reset. Do you want to split this loop into two loops? First would measure, second would apply.

Why would we have to reset this property? It just mirrors resize.style.left, so its life time is meant to match the life time of resizer.
Comment 4 Andrey Kosyakov 2013-01-21 08:09:23 PST
Committed r140335: <http://trac.webkit.org/changeset/140335>