Bug 107284 - [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread
Summary: [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 07:39 PST by Nima Ghanavatian
Modified: 2013-01-18 10:02 PST (History)
1 user (show)

See Also:


Attachments
Patch (23.74 KB, patch)
2013-01-18 08:08 PST, Nima Ghanavatian
no flags Details | Formatted Diff | Diff
Patch (24.22 KB, patch)
2013-01-18 08:55 PST, Nima Ghanavatian
no flags Details | Formatted Diff | Diff
Patch (24.16 KB, patch)
2013-01-18 09:12 PST, Nima Ghanavatian
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-01-18 07:39:08 PST
SSIA
Comment 1 Nima Ghanavatian 2013-01-18 08:08:47 PST
Created attachment 183463 [details]
Patch
Comment 2 Rob Buis 2013-01-18 08:14:23 PST
Comment on attachment 183463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183463&action=review

LGTM.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:167
> +    void callRequestCheckingFor(WTF::PassRefPtr<WebCore::SpellCheckRequest>);

You should not need the WTF prefix.

> Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp:81
> +    WTF::RefPtr<WebCore::Range> rangeForSpellChecking = rangeForSpellCheckingPtr;

Ditto.
Comment 3 Nima Ghanavatian 2013-01-18 08:55:47 PST
Created attachment 183470 [details]
Patch
Comment 4 Rob Buis 2013-01-18 08:58:36 PST
Comment on attachment 183470 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2013-01-18 09:03:54 PST
Comment on attachment 183470 [details]
Patch

Rejecting attachment 183470 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
nk #4 FAILED at 164.
Hunk #5 succeeded at 204 (offset -16 lines).
Hunk #6 FAILED at 268.
2 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.h.rej
patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp
patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15940743
Comment 6 Nima Ghanavatian 2013-01-18 09:12:06 PST
Created attachment 183477 [details]
Patch
Comment 7 Rob Buis 2013-01-18 09:15:21 PST
Comment on attachment 183477 [details]
Patch

Retrying.
Comment 8 Nima Ghanavatian 2013-01-18 10:02:55 PST
landed in r140170