Bug 107283 - Consolidate and run ARIA-list-and-listitem accessibility test
Summary: Consolidate and run ARIA-list-and-listitem accessibility test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 07:38 PST by Brian Holt
Modified: 2013-01-21 10:28 PST (History)
9 users (show)

See Also:


Attachments
Patch proposal (5.13 KB, patch)
2013-01-18 09:00 PST, Brian Holt
no flags Details | Formatted Diff | Diff
2nd patch proposal (5.14 KB, patch)
2013-01-18 09:44 PST, Brian Holt
no flags Details | Formatted Diff | Diff
Made exception for Mac (4.37 KB, patch)
2013-01-21 06:53 PST, Brian Holt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Holt 2013-01-18 07:38:41 PST
After bug 99640, the output from AccessibilityUIElement::role() is consistent across platforms, therefore platform specific tests can be consolidated into a single test and enabled.
Comment 1 Brian Holt 2013-01-18 09:00:58 PST
Created attachment 183472 [details]
Patch proposal
Comment 2 Brian Holt 2013-01-18 09:02:58 PST
Adding people who might be interested to CC.
Comment 3 Alexey Proskuryakov 2013-01-18 09:31:59 PST
Comment on attachment 183472 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=183472&action=review

> LayoutTests/ChangeLog:10
> +        therefore platform specific tests can be consolidated into a

Did you mean to say "platform specific expectations"?
Comment 4 Brian Holt 2013-01-18 09:44:35 PST
Created attachment 183487 [details]
2nd patch proposal
Comment 5 WebKit Review Bot 2013-01-18 10:53:50 PST
Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15957218

New failing tests:
accessibility/aria-list-and-listitem.html
Comment 6 Build Bot 2013-01-18 11:42:40 PST
Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15944666

New failing tests:
accessibility/aria-list-and-listitem.html
Comment 7 Build Bot 2013-01-18 11:49:13 PST
Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15946543

New failing tests:
accessibility/aria-list-and-listitem.html
Comment 8 Brian Holt 2013-01-21 06:53:00 PST
Created attachment 183776 [details]
Made exception for Mac
Comment 9 chris fleizach 2013-01-21 09:05:37 PST
Comment on attachment 183776 [details]
Made exception for Mac

what's the mac exception? i don't see anything referencing an exception with this patch
Comment 10 Brian Holt 2013-01-21 09:36:32 PST
The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal).
Comment 11 chris fleizach 2013-01-21 09:41:57 PST
(In reply to comment #10)
> The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal).

your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)
Comment 12 Brian Holt 2013-01-21 09:46:38 PST
> your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)

I suppose I could have been clearer - what I mean is that the output is now the same on most platforms (i.e. a generic expectation) with the exception of Mac (which still requires a platform-specific expectation). Would you prefer me to update the ChangeLog?
Comment 13 chris fleizach 2013-01-21 09:49:42 PST
Comment on attachment 183776 [details]
Made exception for Mac

thanks. understand now
Comment 14 Brian Holt 2013-01-21 09:53:31 PST
Comment on attachment 183776 [details]
Made exception for Mac

Ready to commit?
Comment 15 WebKit Review Bot 2013-01-21 10:28:26 PST
Comment on attachment 183776 [details]
Made exception for Mac

Clearing flags on attachment: 183776

Committed r140343: <http://trac.webkit.org/changeset/140343>
Comment 16 WebKit Review Bot 2013-01-21 10:28:32 PST
All reviewed patches have been landed.  Closing bug.