Bug 107283 – Consolidate and run ARIA-list-and-listitem accessibility test

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brian Holt]

After bug 99640, the output from AccessibilityUIElement::role() is consistent across platforms, therefore platform specific tests can be consolidated into a single test and enabled.

[Brian Holt]

Created attachment 183472 [details]
Patch proposal

[Brian Holt]

Adding people who might be interested to CC.

[Alexey Proskuryakov]

Comment on attachment 183472 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=183472&action=review

> LayoutTests/ChangeLog:10
> +        therefore platform specific tests can be consolidated into a

Did you mean to say "platform specific expectations"?

[Brian Holt]

Created attachment 183487 [details]
2nd patch proposal

[WebKit Review Bot]

Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15957218

New failing tests:
accessibility/aria-list-and-listitem.html

[Build Bot]

Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15944666

New failing tests:
accessibility/aria-list-and-listitem.html

[Build Bot]

Comment on attachment 183487 [details]
2nd patch proposal

Attachment 183487 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15946543

New failing tests:
accessibility/aria-list-and-listitem.html

[Brian Holt]

Created attachment 183776 [details]
Made exception for Mac

[chris fleizach]

Comment on attachment 183776 [details]
Made exception for Mac

what's the mac exception? i don't see anything referencing an exception with this patch

[Brian Holt]

The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal).

[chris fleizach]

(In reply to comment #10)
> The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal).

your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)

[Brian Holt]

> your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)

I suppose I could have been clearer - what I mean is that the output is now the same on most platforms (i.e. a generic expectation) with the exception of Mac (which still requires a platform-specific expectation). Would you prefer me to update the ChangeLog?

[chris fleizach]

Comment on attachment 183776 [details]
Made exception for Mac

thanks. understand now

[Brian Holt]

Comment on attachment 183776 [details]
Made exception for Mac

Ready to commit?

[WebKit Review Bot]

Comment on attachment 183776 [details]
Made exception for Mac

Clearing flags on attachment: 183776

Committed r140343: <http://trac.webkit.org/changeset/140343>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.